Date: Tue, 7 Feb 2006 16:04:04 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_acct.c Message-ID: <200602071604.k17G445d084802@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2006-02-07 16:04:04 UTC
FreeBSD src repository
Modified files:
sys/kern kern_acct.c
Log:
- Add a kthread to periodically call acctwatch() when accounting is active
instead of calling acctwatch() from softclock. The acctwatch() function
needs to hold an sx lock and also makes a VFS call, and neither of these
are good things (or safe) to do from a callout. The kthread only exists
and is running when accounting is turned on; it is started and stopped
as needed. I didn't run acctwatch() via the thread taskqueue at Robert's
request as he was worried that if the accounting file was over NFS the
VFS_STAT() calls might stall other work on the taskqueue.
- Add an acct_disable() function to take care of closing the accounting
vnode and cleaning up so we don't duplicate the same code in two
different places.
MFC after: 3 days
Revision Changes Path
1.79 +128 -28 src/sys/kern/kern_acct.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602071604.k17G445d084802>