Date: Fri, 3 Nov 2017 02:36:51 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, freebsd-hackers <freebsd-hackers@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Head build unsafe for /etc today Message-ID: <20171103023651.GC34123@FreeBSD.org> In-Reply-To: <20171103022327.GA88659@troutmask.apl.washington.edu> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> <20171103022327.GA88659@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--DIOMP1UsTsWJauNi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 02, 2017 at 07:23:27PM -0700, Steve Kargl wrote: > On Thu, Nov 02, 2017 at 07:08:50PM -0700, Bryan Drewery wrote: > > > On Nov 2, 2017, at 18:49, Steve Kargl <sgk@troutmask.apl.washington.e= du> wrote: > > > You're making changes to the build infrastructure and you're > > > not properly testing it before committing? This is beyond > > > pointyhat material.=20 > >=20 > > I ran 2 universes, dozens of buildworlds and buildkernels, > > dozens of installworld and installkernel, several xdev and > > native-xtools, several full DIRDEPS_BUILD builds and bootstraps, > > ran subdir builds, ran subdir cleans, tested several targets together, > > ran various special case tests for submakes, played around with a > > ton of MAKEOBJDIRPREFIX cases, handled and tested symlinked objdirs > > special, ran it through my work repro a few times, did special > > testing in rescue/, and had a volunteer test release. In the process > > I found a bmake bug, GPL_DTC build bug and several others I don=E2=80= =99t > > recall from the bus. > >=20 > > What I missed was the =E2=80=9Cclean=E2=80=9D buildworld because I forg= ot it > > even exists. I=E2=80=99ve wanted to remove it for a year. I also forgot= to > > test buildenv. > >=20 >=20 > If you did all the above under META_MODE, then no you did not=20 > buildworld and buildkernel and all the other stuff you claim. > If your first step isn't 'cd /usr/obj ; rm -rf *' or equivalent > in whatever jail you use, then you're not properly testing=20 > your changes to the build infrastructure. I did test this, personally, and missed it. > As you have demonstrated, > Makefile, Makefile.inc1, and the *.mk files are sufficiently=20 > complicated that proper testing should be done, and proper=20 > testing means one doesn't takes shortcuts. >=20 Mistakes happen. Things sometimes get accidentally missed. Glen --DIOMP1UsTsWJauNi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAln71j4ACgkQAxRYpUeP 4pNCcg/+MYE8KZ7MuCX+sO+Alc0QISpF5JosxGS8FukLMEb1oKM14ad9xChSRKHZ fHgm+1yehr5ENrRBGw76RMsAQBt/UjQjHTVtA/x9wU+sWcSgcRMp5BQzur7WM/Yf R5fiau5YvFFJdNm6igrh2hSEgNSp7WznSGOm6bcIk8rS1dxBsRvjLcdXa1HBgudY uR3mysZyy3pG1ZPh7k3Wtv+4eziDnkffv5rJQBVgCPHFu3jT67ctPq8lu2hEeyCk uxA3pISrqTFvdIczKXkUpcL9yaECCth/Lstcr68e0byKx4KvdyRW9/7x7NCNYes8 EXGiFu5YXBmdLr9onQ0LybkhGFjIo6xfRf+r8q9ge8XNO9Ar7D2UeyU4tiJx3g5L xHn/PzkkLg1f4Q8Pd1r86vXNBAI6CJmDQEpBR2ascT3Q7bPSLcPXuDE1VXpeoEeN Py0fjP41BdHli2XJo0jc7qBxsX8pQ5BjR9kbx3UBjUTZDORHRSj7THEkwv6kQgHx UCVIeAepty402yQJgBzgar2HQ+nd9zznliTPtygn42zaIOvTAWqAvYP+7DGBw0cR bS6TOXgt0MBDR5p1Hf9EdYeB5n4owwcsU0V2tBDC/uvoE8w6r9Gw8dH6GIzkXp1c fODMpzsoGg83i8MgslbelsQQKQrCZiywsByZkrlJLZ8tkZAZjlg= =DwAh -----END PGP SIGNATURE----- --DIOMP1UsTsWJauNi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171103023651.GC34123>