Date: Tue, 4 Dec 2012 03:46:55 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Eitan Adler <lists@eitanadler.com> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r243850 - stable/9/sys/kern Message-ID: <20121204014655.GN3013@kib.kiev.ua> In-Reply-To: <CAF6rxgmTEYmgRmn7UO%2Bv293mH8RZ63Ago6cZ8ENoc-C=g9T5uw@mail.gmail.com> References: <201212040054.qB40snD5001979@svn.freebsd.org> <CAF6rxgmTEYmgRmn7UO%2Bv293mH8RZ63Ago6cZ8ENoc-C=g9T5uw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--aaeYxw/B9teUOk8U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 03, 2012 at 07:58:09PM -0500, Eitan Adler wrote: > On 3 December 2012 19:54, Konstantin Belousov <kib@freebsd.org> wrote: > > Author: kib > > Date: Tue Dec 4 00:54:49 2012 > > New Revision: 243850 > > URL: http://svnweb.freebsd.org/changeset/base/243850 > > > > Log: > > MFC r243341: > > Add a special meaning to the negative ticks argument for > > taskqueue_enqueue_timeout(). Do not rearm the callout if it is > > already armed and the ticks is negative. Otherwise rearm it to fire > > in abs(ticks) ticks in the future. >=20 > Why was this not MFCed together with r243845 ? Because r243845 was only committed today, and I do not see a need to postpone the merge of the fix for the (rare) bug. Less formal, I do not see much use in the single commit spanning both sys and non-sys. We almost never should have such interlock, otherwise ABI issues would cause troubles for people updating the system. And spanning commits are somewhat more cumbersome to both merge, revert and for non-developer to pick. --aaeYxw/B9teUOk8U Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQvVYOAAoJEJDCuSvBvK1B0OwP/0a2FhkePmZDTj0PbKYtr4Xz 2FwooqSVQjBSHd2H7EiZoVGOUGBrrzP2r6KzgA8L5ipgLlasnW3MGBoiXF1wu8z9 gju6aV8SoH4+kp1pjG/Z/VSLeqc8qO4245yczdY2Ska1HDpuiVBrQqv8XW0r1+PI vprfjz6LWXg5lNbK8KzZ5hSB+OoRCGxhYLD/ngX0kJax6O8J7yC5ZM8YK3sML505 Q10B3bTq7AcqUBHi3hLi7LVqq4lXGdyJeE01aVcyxUXQqzkY9rQOW4sRBrGPfI6G EY1b4djmZ/TY5hq3FNCJOmwW4lR0RXfcUTpZehXqtQxQDw5rodIP2NFfCfdW/5nz cz4UegNIB45A4hqeZXViqBgsTrV4sNrC6T61pD2LdAXe4QrbLuDJ5jyJhCQQKqo5 umXLBM5nl2W6KOHe4ZS67hqWgAcU0KS2XwaxFEwD6mObnLcZFqjqpn44CUHLotAi KBlxWBlHIwI7gTzm+RCuhMafaRtv4UhefNQ0qLuCuigIfFbQx3YncjOco/tgG4Gv 1QaBDxw4gpf1Wisl/qPpGRnLRcU7CWbAqALJ8MYPiOB3XAWf/MqIXRGO79/N9O/k ZFG3H3Z83z01ubXNtXj+DLejJAtssty9F9OhnkSiWL3X93sJsmCrztvlpSTHPaK9 +hij9S2MAvxPT9YRxTXB =1mgo -----END PGP SIGNATURE----- --aaeYxw/B9teUOk8U--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121204014655.GN3013>