Date: Sat, 23 Mar 2024 16:38:03 +0100 From: "Tobias C. Berner" <tcberner@gmail.com> To: Po-Chuan Hsieh <sunpoet@freebsd.org>, Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <2567403.0dHE6SNnxz@angua.firefly> In-Reply-To: <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Am Samstag, 23. März 2024, 15:14:01 CET schrieb Gleb Popov: > On Sat, Mar 23, 2024 at 5:04 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > > The branch main has been updated by sunpoet: > > > > URL: > > https://cgit.FreeBSD.org/ports/commit/?id=28472e9722d808739a4d690f6d803a2 > > b1b8f5f98 > > > > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-03-23 14:01:07 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-03-23 14:01:07 +0000 > > > > Revert "x11-fonts/noto*: Restructure and update" > > > > This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. > > It is good manners to explain the reason for reverting when doing it. > Even better to first talk to the original committer and ask him to the > revert. Moin moin I completely agree. Given that there has been a phabricator review open for two months, with you, sunpoet@ as reviewer, this is looking like poor judgement on your side. As arrowd@ points out, you should have commented on the reverted commit first, and elaborate your reasoning for a revert. Simply reverting the work of others may lead to fewer contributions. Please take this into consideration in the future. mfg Tobias [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEulg44mHRo8gJYMULAh23OlApOtAFAmX+91xfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJB NTgzOEUyNjFEMUEzQzgwOTYwQzUwQjAyMURCNzNBNTAyOTNBRDAACgkQAh23OlAp OtDDWwf/RpLL4gb3zMpLkstx/VxelrEfyRDf0H2zj+9ZSKLsFsS2FePgj1Yjq1AD 7qyj1j0zYEr/X6ytRDDmiXjNR/regEH4VnVVhpOTWnect3NRUY33SyhlmDXRvxJO 2uULHoJDMYhzqvfa3Hct8a3LC53AZMyRE1oJb8gJz2aueJhtBN2i49wzJ/EoHNtJ l1ep78nsm6i2O/H1UJiqLfPagyagk6WK6IUygPmxI8jp6rKGzJtiTJNU32lc1jv3 e70H3dyJT1FKW8i5t9/D39nJ4ErORJYPa/tYbCkG7w6Iro5pd8zX87PM0qSuxXVL OMgV/A6HsfDPKFD1W5wYexvcRf1ZRQ== =eiWP -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2567403.0dHE6SNnxz>