Date: Sat, 20 Jan 2018 18:52:02 +0000 From: rgrimes <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D13995: NVMe controller emulator for bhyve. Message-ID: <088f28d2d722207066144b380a0d7fac@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-vgewguea2dhplsjkeozl-req@FreeBSD.org> References: <differential-rev-PHID-DREV-vgewguea2dhplsjkeozl-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
rgrimes added a comment. I did a very quick one time scan down the code just to see what was here, these are my comments about it. None of the functions have block start comments stating what that function does. INLINE COMMENTS > pci_nvme.c:1 > +#include <stdio.h> > +#include <stdlib.h> File is missing a copyright, and a $FreeBSD$, where did this code come from? Who wrote it? > pci_nvme.c:850 > + > + > + int data_size = number_of_lb * logic_block_size; style nit, extra blank line > pci_nvme.c:985 > +/* pci_generate_msix(sc->pi, sq_info->completion_qid); */ > +/* } */ > + Why is this code here and all commented out? #if 0/#endif would make this more readable. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sux2mfgj_gmail.com, grehan, trasz, imp Cc: rgrimes, cem, freebsd-virtualization-list, chuckhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?088f28d2d722207066144b380a0d7fac>