Date: Thu, 6 Mar 2003 20:39:05 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netsmb smb_dev.c smb_subr.h src/sys/fs/smbfs smbfs_node.h smbfs_vfsops.c smbfs_vnops.c Message-ID: <20030306183905.GB78034@sunbay.com> In-Reply-To: <20030306181058.GA40027@dragon.nuxi.com> References: <200303061038.h26AcJWL095388@repoman.freebsd.org> <20030306153455.GD55489@sunbay.com> <20030306181058.GA40027@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0ntfKIWw70PvrIHh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 06, 2003 at 10:10:58AM -0800, David O'Brien wrote: > On Thu, Mar 06, 2003 at 05:34:55PM +0200, Ruslan Ermilov wrote: > > Thanks. I think that __FreeBSD_version ifdefs inside the src/ > > are generally bogus and should be removed, unless the code is > > kept the same (by the maintainer) for different branches. >=20 > ... werid, you're the ones that keep adding them to things I maintain... >=20 There's the subtle difference here. Nobody is guaranteed to compile HEAD sources under RELENG_4 -- this may or may not work, no guarantees. The things I add the __FreeBSD_version to are sometimes compiled on older FreeBSD versions. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --0ntfKIWw70PvrIHh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+Z5XJUkv4P6juNwoRAjkXAJ92KGACdlxXZYSlLaIYuIbExFNtSQCeN35Q 8dX57frhihjeXWnlj+9AqUE= =7npD -----END PGP SIGNATURE----- --0ntfKIWw70PvrIHh-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030306183905.GB78034>