Date: Tue, 10 Mar 2015 09:52:58 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 197265] [mii] patch to support rtl8211f ethernet phys Message-ID: <bug-197265-2472-YrKMLK5I3e@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197265-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-197265-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197265 --- Comment #4 from Pyun YongHyeon <yongari@FreeBSD.org> --- Thanks for the patch. I didn't test your patch on real H/W yet but patch looks good to me. To improve readability I've slightly reorganized your patch and regenerated it against HEAD. One difference against your diff is direct access of RGEPHY_F_MII_SSR register in MII_TICK handler. I wanted to remove RGEPHY_MII_BMSR, RGEPHY_MII_BMCR register accesses in the handler and rely on RGEPHY_F_MII_SSR or RGEPHY_MII_SSR register for non-re(4) drivers. Of course this assumes RGEPHY_F_MII_SSR reports correct link state in various timings. Would you try attached patch and let me know how it goes? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197265-2472-YrKMLK5I3e>