Date: Sun, 18 Jan 2009 16:49:13 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Stanislav Sedov <stas@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187395 - head/sys/gnu/fs/ext2fs Message-ID: <20090118144913.GU48057@deviant.kiev.zoral.com.ua> In-Reply-To: <20090118174357.3ed1459d.stas@FreeBSD.org> References: <200901181404.n0IE4uXw075698@svn.freebsd.org> <20090118140644.GT48057@deviant.kiev.zoral.com.ua> <20090118174357.3ed1459d.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Jan 18, 2009 at 05:43:57PM +0300, Stanislav Sedov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Sun, 18 Jan 2009 16:06:44 +0200 > Kostik Belousov <kostikbel@gmail.com> mentioned: > > > > > Please see a discussion on the fs@ and reasoning why I declined to commit > > the similar patch. > > > > I'm sorry I've missed that discussion entirely, but I can admit I had all the > same concerns while reviewing the patch, and Alex's comments and Linux code > reading made me fully confident that the modifications are safe and correct. > Let me explain why I think so. > > The extra size added in inodes are used to store additional info like extended > attributes, ACLs and so on. Each inode now has a field just after the legacy > inode format struct that shows hom much additional space has been added to > this particular inode. By analyzing this field the operating system can interpret > additional data located in inode, if it understand its format (there might be > application and/or OS specific data too). > > Our implementation just ignore this additional fields after sizeof(ext2fs_inode), > both while reading and writing. Thus we don't interet this data yet we don't > overwrite it. Then, it is ok if you did read the code and became assured that ignoring the additional inode data is safe. In any case, consider yourself an appointed ext2fs maintainer onward. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklzQWgACgkQC3+MBN1Mb4hvgwCeLfZnxjThRBzNLf5IPCOu8AFH HQUAnR4R3/wHWRa4G3KKmwWLFzjCfKxb =lPTr -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090118144913.GU48057>