Date: Tue, 09 Apr 2002 16:27:20 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, kris@obsecurity.org, "M. Warner Losh" <imp@village.org>, Alfred Perlstein <bright@mu.org> Subject: Re: cvs commit: src/sys/sys ioccom.h Message-ID: <XFMail.20020409162720.jhb@FreeBSD.org> In-Reply-To: <20020409131837.D35868@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09-Apr-2002 David O'Brien wrote: > On Mon, Apr 08, 2002 at 11:42:42PM -0700, Alfred Perlstein wrote: >> > : No, I already said that I reverted the ()'s locally and it still failed >> > : to >> > : compile. Yes, I was editing /usr/include/sys/ioccom.h and not >> > : /sys/sys/ioccom.h. I also tried putting __P() back in, but it didn't >> > : build >> > : then either. I'm wondering if the pollution in screen's osdef.h is new? > ... >> > The real problem is at osdef.h:81: >> > extern int ioctl __P((int, int, char *)); >> > >> > Note the two problems with this: >> > 1) int doesn't match unsgined long >> > 2) char * doesn't match ... >> > >> > screen needs to be fixed. here's a real patch: > ... >> I don't have the emails offhand, but the screen people were pretty >> quick to respond to a help message from me. Have you contacted them >> about bringing in this fix? > > While fixing screen is a good thing to do. Nobody seems to be able to > determine just WHICH commit broke building it. I think we should determine > that before "fixing" it. Warner did already. The de- __P()'ing did because the regex they use to find function prototypes in the system headers didn't match the de- __P()'d prototypes. This was the same breakage that broke hylafax and vim according to Warner's earlier e-mail. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020409162720.jhb>