Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Dec 2025 12:45:02 +0000
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Cc:        Simon Wollwage <rootnode+freebsd@wollwage.com>
Subject:   git: eaa424e3bde8 - main - snmp_pf: remove errno usage after pfctl_get_status_h change
Message-ID:  <694e834e.30a7d.557e5bfc@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=eaa424e3bde88f005c91f87a799c1905f1a5ebf5

commit eaa424e3bde88f005c91f87a799c1905f1a5ebf5
Author:     Simon Wollwage <rootnode+freebsd@wollwage.com>
AuthorDate: 2025-12-26 10:47:26 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-12-26 10:50:37 +0000

    snmp_pf: remove errno usage after pfctl_get_status_h change
    
    pfctl_get_status_h() does not set errno, so don't log it.
    
    PR:             291936
    Reviewed by:    kp
---
 usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c b/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
index b62ecf791500..f01218bee5f8 100644
--- a/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
+++ b/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
@@ -1288,8 +1288,7 @@ pfs_refresh(void)
 	pfs = pfctl_get_status_h(pfh);
 
 	if (pfs == NULL) {
-		syslog(LOG_ERR, "pfs_refresh(): ioctl(): %s",
-		    strerror(errno));
+		syslog(LOG_ERR, "pfs_refresh(): pfctl_get_status failure");
 		return (-1);
 	}
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?694e834e.30a7d.557e5bfc>