Date: Wed, 19 Mar 2014 10:32:57 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r263343 - stable/9/lib/libprocstat Message-ID: <201403191032.s2JAWvnR079470@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rwatson Date: Wed Mar 19 10:32:57 2014 New Revision: 263343 URL: http://svnweb.freebsd.org/changeset/base/263343 Log: Merge r262690 from head to stable/9: When querying a process's umask via sysctl in libprocstat(), don't print a warning if EPERM is returned as this is an expected failure mode rather than error -- similar to current handling of ESRCH. This makes the output of 'procstat -as' vastly more palatable. Sponsored by: DARPA, AFRL Modified: stable/9/lib/libprocstat/libprocstat.c Directory Properties: stable/9/lib/libprocstat/ (props changed) Modified: stable/9/lib/libprocstat/libprocstat.c ============================================================================== --- stable/9/lib/libprocstat/libprocstat.c Wed Mar 19 10:20:13 2014 (r263342) +++ stable/9/lib/libprocstat/libprocstat.c Wed Mar 19 10:32:57 2014 (r263343) @@ -2053,7 +2053,7 @@ procstat_getumask_sysctl(pid_t pid, unsi mib[3] = pid; len = sizeof(*maskp); error = sysctl(mib, 4, maskp, &len, NULL, 0); - if (error != 0 && errno != ESRCH) + if (error != 0 && errno != ESRCH && errno != EPERM) warn("sysctl: kern.proc.umask: %d", pid); return (error); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403191032.s2JAWvnR079470>