Date: Thu, 1 Dec 2011 11:03:55 +0000 From: Alexander Best <arundel@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r228148 - head/sys/conf Message-ID: <20111201110355.GA60151@freebsd.org> In-Reply-To: <CAGH67wSX1m8K-Dtmsjp-nYm7VzSuRvUE3JTbF9b2CONFqkAu3A@mail.gmail.com> References: <201111292128.pATLSnKr067459@svn.freebsd.org> <20111201005932.GA54417@freebsd.org> <CAGH67wSX1m8K-Dtmsjp-nYm7VzSuRvUE3JTbF9b2CONFqkAu3A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed Nov 30 11, Garrett Cooper wrote: > On Wed, Nov 30, 2011 at 4:59 PM, Alexander Best <arundel@freebsd.org> wrote: > > On Tue Nov 29 11, John Baldwin wrote: > >> Author: jhb > >> Date: Tue Nov 29 21:28:48 2011 > >> New Revision: 228148 > >> URL: http://svn.freebsd.org/changeset/base/228148 > >> > >> Log: > >> Remove a bit of debugging that accidentally crept in earlier. > >> > >> Modified: > >> head/sys/conf/newvers.sh > >> > >> Modified: head/sys/conf/newvers.sh > >> ============================================================================== > >> --- head/sys/conf/newvers.sh Tue Nov 29 20:06:27 2011 (r228147) > >> +++ head/sys/conf/newvers.sh Tue Nov 29 21:28:48 2011 (r228148) > >> @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; > >> done > >> > >> if [ -n "$svnversion" ] ; then > >> - echo "$svnversion" > >> svn=`cd ${SYSDIR} && $svnversion` > > > > any chance we could replace $svnversion with something like the following: > > > > 'svn info|grep ^Revision|sed 's/^Revision: //'' ? > > > > this is much faster and the only downside seems to be the missing {MSP} at the > > end. > > > > running a standard hdd, svnversion takes almost half a minute, while the > > command above finishes in < 0.1 seconds. > > We already hashed over that in the last discussion. svnversion was > picked because it iterates over the entire tree and you know for an > absolute fact that it's running versions X-Y-Z, instead of the version > of the Makefile being X. sorry. wasn't aware of that. thanks for the info. cheers. alex > Thanks, > -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111201110355.GA60151>