Date: Wed, 29 Sep 2010 23:33:58 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213270 - head/etc/rc.d Message-ID: <4CA42F56.4070604@FreeBSD.org> In-Reply-To: <201009291308.o8TD8NHo009975@svn.freebsd.org> References: <201009291308.o8TD8NHo009975@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 9/29/2010 6:08 AM, Ed Maste wrote: | Author: emaste | Date: Wed Sep 29 13:08:23 2010 | New Revision: 213270 | URL: http://svn.freebsd.org/changeset/base/213270 | | Log: | /etc/rc.d/defaultroute currently bails immediately if all interfaces | set to use DHCP have no carrier. This can cause grief as it may take | some time for link to be established, and defaultroute may terminate | before this happens. | | Introduce a defaultroute_carrier_delay variable and then wait that long | in defaultroute before bailing if no interfaces have carrier. With the | default settings defaultroute will wait for five seconds for this, and | the original 30 second wait for a default route to appear is unchanged. | Note that there is in discussion an alternative approach to the broader | problem of waiting for DHCP-configured routes. However, this change | addresses a real problem in the current defaultroute script. | | Discussed on: freebsd-rc@ Ed, I'm always excited to see people take an interest in rc.d, especially when they post stuff for review. When I posted this message: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=17533+0+current/freebsd-rc it was intended to be a request for you to review Jeremy's more generic solution to see if it was suitable for your needs, and correspondingly a request to hold off committing your solution until that question was answered. I apologize if I wasn't clear about that. While I think your approach here is creative, I'd rather see a more generic solution to the "system needs network connectivity before proceeding past point X" problem. Could you please back this (and your related changes) out, and evaluate Jeremy's script? I, and other users have evaluated it for some time now and found it effective; and I'd like to see it committed, especially now that Jeremy has updated it. Thanks, Doug - -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (MingW32) iQEcBAEBCAAGBQJMpC9WAAoJEFzGhvEaGryEZi4H/3eojCGkfCvrWv79gr8H/cBH MwSVzDJvKiNakXk8/+BW2qoT0B+TWELSZ3VYt5s0pvJIUV6/0IjchEn8V8keCJUv 6gIYUgfeiLi6Ie9CtsF2igRAT8ZTVifJfCCUf4UI6wE7n7r6dAUmotloBhqREhn+ BU4C35653wNAsbs1QVw9GQWbPCbBNpikxXLExj/Xo5o0rh2VsKxF6BfVuUUwFrjp QB5eQsEVk+68QFAzSwNEcXfW9882BnioTg7+vAZaUf5tzjseSiLB8EwuLf8dM3Ic EG23/QZInRiT4Atx8UKRPqhiMeLvdnDQjue0bKRIibCh9Zt83OT03Mkhzx9JRwQ= =2XcL -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CA42F56.4070604>