Date: Sun, 24 Mar 2024 00:12:07 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: "Tobias C. Berner" <tcberner@gmail.com>, Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <CAMHz58Qa2pyN6qs-mFr9aHgtQoGrd1hbhF=ahx5ahR-0CB-7uQ@mail.gmail.com> In-Reply-To: <2567403.0dHE6SNnxz@angua.firefly> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> <2567403.0dHE6SNnxz@angua.firefly>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Mar 23, 2024 at 11:38 PM Tobias C. Berner <tcberner@gmail.com> wrote: > Am Samstag, 23. März 2024, 15:14:01 CET schrieb Gleb Popov: > > On Sat, Mar 23, 2024 at 5:04 PM Po-Chuan Hsieh <sunpoet@freebsd.org> > wrote: > > > The branch main has been updated by sunpoet: > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=28472e9722d808739a4d690f6d803a2 > > > b1b8f5f98 > > > > > > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 > > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > > AuthorDate: 2024-03-23 14:01:07 +0000 > > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > > CommitDate: 2024-03-23 14:01:07 +0000 > > > > > > Revert "x11-fonts/noto*: Restructure and update" > > > > > > This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. > > > > It is good manners to explain the reason for reverting when doing it. > > Even better to first talk to the original committer and ask him to the > > revert. > > Moin moin > > I completely agree. Given that there has been a phabricator review open > for > two months, with you, sunpoet@ as reviewer, this is looking like poor > judgement on your side. > > As arrowd@ points out, you should have commented on the reverted commit > first, > and elaborate your reasoning for a revert. > > Simply reverting the work of others may lead to fewer contributions. > Please > take this into consideration in the future. > > > mfg Tobias Hello, I'm sorry that I did not put enough information in this reverting commit because I need it to be done ASAP so that less users are affected. There are several reasons I reverted it by myself instead of requesting tijl@ to do so. First, I do not use phab review therefore I did not really review the patch which means it is committed without maintainer approval. Second, I already have my own work for noto updates which is totally in different direction with tijl@'s work. I cannot simply rebase my work onto it. Third, The problem mentioned in the PR is also handled in my own work. Regards, sunpoet [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Sat, Mar 23, 2024 at 11:38 PM Tobias C. Berner <<a href="mailto:tcberner@gmail.com" target="_blank">tcberner@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am Samstag, 23. März 2024, 15:14:01 CET schrieb Gleb Popov:<br> > On Sat, Mar 23, 2024 at 5:04 PM Po-Chuan Hsieh <<a href="mailto:sunpoet@freebsd.org" target="_blank">sunpoet@freebsd.org</a>> wrote:<br> > > The branch main has been updated by sunpoet:<br> > > <br> > > URL:<br> > > <a href="https://cgit.FreeBSD.org/ports/commit/?id=28472e9722d808739a4d690f6d803a2" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=28472e9722d808739a4d690f6d803a2</a><br>; > > b1b8f5f98<br> > > <br> > > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98<br> > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > > AuthorDate: 2024-03-23 14:01:07 +0000<br> > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > > CommitDate: 2024-03-23 14:01:07 +0000<br> > > <br> > > Revert "x11-fonts/noto*: Restructure and update"<br> > > <br> > > This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8.<br> > <br> > It is good manners to explain the reason for reverting when doing it.<br> > Even better to first talk to the original committer and ask him to the<br> > revert.<br> <br> Moin moin <br> <br> I completely agree. Given that there has been a phabricator review open for <br> two months, with you, sunpoet@ as reviewer, this is looking like poor <br> judgement on your side. <br> <br> As arrowd@ points out, you should have commented on the reverted commit first, <br> and elaborate your reasoning for a revert. <br> <br> Simply reverting the work of others may lead to fewer contributions. Please <br> take this into consideration in the future.<br> <br> <br> mfg Tobias</blockquote><div><br></div><div>Hello,</div><div><br></div><div>I'm sorry that I did not put enough information in this reverting commit because I need it to be done ASAP so that less users are affected.</div><div>There are several reasons I reverted it by myself instead of requesting tijl@ to do so.</div><div>First, I do not use phab review therefore I did not really review the patch which means it is committed without maintainer approval.</div><div>Second, I already have my own work for noto updates which is totally in different direction with tijl@'s work. I cannot simply rebase my work onto it.</div><div>Third, The problem mentioned in the PR is also handled in my own work.</div><div><br></div><div>Regards,</div><div>sunpoet</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Qa2pyN6qs-mFr9aHgtQoGrd1hbhF=ahx5ahR-0CB-7uQ>