Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 09 Jun 2024 09:08:25 +0200
From:      Daniel Engberg <daniel.engberg.lists@pyret.net>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 187b969b8f9f - main - graphics/svgpp: new port had  been added (+)
Message-ID:  <96134cbe563ec73933802de201a9b640@mail.infomaniak.com>
In-Reply-To: <202406090626.4596QEei093326@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 2024-06-09T08:26:14.000+02:00, Alexey Dokuchaev <danfe@FreeBSD.org>
wrote:

> The branch main has been updated by danfe:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=187b969b8f9f0ed850f0dc7eb8d08b6d961f1346
> 
> commit 187b969b8f9f0ed850f0dc7eb8d08b6d961f1346
> 
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> 
> AuthorDate: 2024-06-09 06:25:00 +0000
> 
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> 
> CommitDate: 2024-06-09 06:25:00 +0000
> 
>     graphics/svgpp: new port had been added (+)
> 
>     
> 
>     SVG++ library can be thought of as a framework, containing parsers
> 
>     for various SVG syntaxes, adapters that simplify handling of parsed
> 
>     data, and other utilities and helpers for the most common tasks.
> 
>     
> 
>     WWW: http://svgpp.org/
> 
> ---
> 
>  graphics/Makefile        |   1 +
> 
>  graphics/svgpp/Makefile  |  20 +++++
> 
>  graphics/svgpp/distinfo  |   3 +
> 
>  graphics/svgpp/pkg-descr |   3 +
> 
>  graphics/svgpp/pkg-plist | 192 +++++++++++++++++++++++++++++++++++++++++++++++
> 
>  5 files changed, 219 insertions(+)
> 
> diff --git a/graphics/Makefile b/graphics/Makefile
> 
> index 8e12cafd0e4e..4a3bb391f03a 100644
> 
> --- a/graphics/Makefile
> 
> +++ b/graphics/Makefile
> 
> @@ -1152,6 +1152,7 @@
> 
>      SUBDIR += svg2png
> 
>      SUBDIR += svgalib
> 
>      SUBDIR += svgbob
> 
> +    SUBDIR += svgpp
> 
>      SUBDIR += swappy
> 
>      SUBDIR += swfmill
> 
>      SUBDIR += swftools
> 
> diff --git a/graphics/svgpp/Makefile b/graphics/svgpp/Makefile
> 
> new file mode 100644
> 
> index 000000000000..505090385589
> 
> --- /dev/null
> 
> +++ b/graphics/svgpp/Makefile
> 
> @@ -0,0 +1,20 @@
> 
> +PORTNAME=    svgpp
> 
> +PORTVERSION=    1.3.1
> 
> +DISTVERSIONPREFIX=    v
> 
> +CATEGORIES=    graphics
> 
> +
> 
> +MAINTAINER=    danfe@FreeBSD.org
> 
> +COMMENT=    C++ header-only parsers for various SVG syntaxes
> 
> +WWW=        http://svgpp.org/
> 
> +
> 
> +LICENSE=    BSL
> 
> +LICENSE_FILE=    ${WRKSRC}/LICENSE_1_0.txt
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +NO_BUILD=    yes
> 
> +NO_ARCH=    yes
> 
> +
> 
> +do-install:
> 
> +    ${CP} -a ${WRKSRC}/include/ ${STAGEDIR}${PREFIX}/include
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> ...

Hi,

While this works you can please consider to follow Porters
Handbookregarding use of USE_GITHUB section (see examples) and
COPYTREE_SHARE macro instead of cp for consistency?

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

https://docs.freebsd.org/en/books/porters-handbook/book/#install-copytree

Best regards,

Daniel


[-- Attachment #2 --]
<html><body><div>On 2024-06-09T08:26:14.000+02:00, Alexey Dokuchaev &lt;danfe@FreeBSD.org&gt; wrote:<br></div><div ><div><br></div></div><div><br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by danfe:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=187b969b8f9f0ed850f0dc7eb8d08b6d961f1346" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=187b969b8f9f0ed850f0dc7eb8d08b6d961f1346</a><br></div><div><br></div><div>commit 187b969b8f9f0ed850f0dc7eb8d08b6d961f1346<br></div><div>Author:     Alexey Dokuchaev &lt;<a class="defaultMailLink" href="mailto:danfe@FreeBSD.org">danfe@FreeBSD.org</a>&gt;<br></div><div>AuthorDate: 2024-06-09 06:25:00 +0000<br></div><div>Commit:     Alexey Dokuchaev &lt;<a class="defaultMailLink" href="mailto:danfe@FreeBSD.org">danfe@FreeBSD.org</a>&gt;<br></div><div>CommitDate: 2024-06-09 06:25:00 +0000<br></div><div><br></div><div>    graphics/svgpp: new port had been added (+)<br></div><div>    <br></div><div>    SVG++ library can be thought of as a framework, containing parsers<br></div><div>    for various SVG syntaxes, adapters that simplify handling of parsed<br></div><div>    data, and other utilities and helpers for the most common tasks.<br></div><div>    <br></div><div>    WWW: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://svgpp.org/" target="_blank">http://svgpp.org/</a><br></div><div>---<br></div><div>; graphics/Makefile        |   1 +<br></div><div> graphics/svgpp/Makefile  |  20 +++++<br></div><div> graphics/svgpp/distinfo  |   3 +<br></div><div> graphics/svgpp/pkg-descr |   3 +<br></div><div> graphics/svgpp/pkg-plist | 192 +++++++++++++++++++++++++++++++++++++++++++++++<br></div><div> 5 files changed, 219 insertions(+)<br></div><div><br></div><div>diff --git a/graphics/Makefile b/graphics/Makefile<br></div><div>index 8e12cafd0e4e..4a3bb391f03a 100644<br></div><div>--- a/graphics/Makefile<br></div><div>+++ b/graphics/Makefile<br></div><div>@@ -1152,6 +1152,7 @@<br></div><div>     SUBDIR += svg2png<br></div><div>     SUBDIR += svgalib<br></div><div>     SUBDIR += svgbob<br></div><div>+    SUBDIR += svgpp<br></div><div>     SUBDIR += swappy<br></div><div>     SUBDIR += swfmill<br></div><div>     SUBDIR += swftools<br></div><div>diff --git a/graphics/svgpp/Makefile b/graphics/svgpp/Makefile<br></div><div>new file mode 100644<br></div><div>index 000000000000..505090385589<br></div><div>--- /dev/null<br></div><div>+++ b/graphics/svgpp/Makefile<br></div><div>@@ -0,0 +1,20 @@<br></div><div>+PORTNAME=	svgpp<br></div><div>+PORTVERSION=	1.3.1<br></div><div>+DISTVERSIONPREFIX=	v<br></div><div>+CATEGORIES=	graphics<br></div><div>+<br></div><div>+MAINTAINER=	<a class="defaultMailLink" href="mailto:danfe@FreeBSD.org">danfe@FreeBSD.org</a><br></div><div>+COMMENT=	C++ header-only parsers for various SVG syntaxes<br></div><div>+WWW=		<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://svgpp.org/" target="_blank">http://svgpp.org/</a><br></div><div>+<br></div><div>+LICENSE=	BSL<br></div><div>+LICENSE_FILE=	${WRKSRC}/LICENSE_1_0.txt<br></div><div>+<br></div><div>+USE_GITHUB=	yes<br></div><div>+NO_BUILD=	yes<br></div><div>+NO_ARCH=	yes<br></div><div>+<br></div><div>+do-install:<br></div><div>+	${CP} -a ${WRKSRC}/include/ ${STAGEDIR}${PREFIX}/include<br></div><div>+<br></div><div>+.include &lt;<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk>" target="_blank">bsd.port.mk&gt;</a>;<br></div><div>...<br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>While this works you can please consider to follow Porters Handbookregarding use of USE_GITHUB section (see examples) and COPYTREE_SHARE macro instead of cp for consistency?<br></div><div><br></div><div><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github</a><br></div><div><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#install-copytree" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#install-copytree</a><br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body></html>

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96134cbe563ec73933802de201a9b640>