Date: Mon, 21 Apr 2008 09:35:47 GMT From: Ivan Voras <ivoras@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/122957: ath_hal is too verbose when booting Message-ID: <200804210935.m3L9ZlNF052863@www.freebsd.org> Resent-Message-ID: <200804210940.m3L9e1b2089326@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 122957
>Category: kern
>Synopsis: ath_hal is too verbose when booting
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 21 09:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Ivan Voras
>Release: 7.x
>Organization:
>Environment:
FreeBSD 7.0-RELEASE
>Description:
ath_hal kernel module is too verbose when booting. It always prints its banner instead of only when in bootverbose mode.
>How-To-Repeat:
Boot any recent FreeBSD. Observe message:
ath_hal: 0.9.20.3 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413, RF5413)
Drivers shouldn't display their banners when the hardware they support isn't there.
>Fix:
See patch.
Patch attached with submission follows:
--- ath_old/ah_osdep.c 2008-04-18 11:22:53.000000000 +0200
+++ ath/ah_osdep.c 2008-04-18 11:23:48.000000000 +0200
@@ -411,13 +411,15 @@
switch (type) {
case MOD_LOAD:
- printf("ath_hal: %s (", ath_hal_version);
- sep = "";
- for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
- printf("%s%s", sep, ath_hal_buildopts[i]);
- sep = ", ";
+ if (bootverbose) {
+ printf("ath_hal: %s (", ath_hal_version);
+ sep = "";
+ for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
+ printf("%s%s", sep, ath_hal_buildopts[i]);
+ sep = ", ";
+ }
+ printf(")\n");
}
- printf(")\n");
return 0;
case MOD_UNLOAD:
return 0;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804210935.m3L9ZlNF052863>