Date: Thu, 31 May 2012 18:29:07 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Tom Judge <tj@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: svn commit: r236362 - head/share/misc Message-ID: <4FC81AE3.10304@FreeBSD.org> In-Reply-To: <201205311933.q4VJXpnE060290@svn.freebsd.org> References: <201205311933.q4VJXpnE060290@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/31/2012 12:33 PM, Tom Judge wrote:
> - Sort the node list while I'm here.
This falls under the category of a "whitespace" change, which should
have been done as a separate commit (usually first, then substantive
changes second).
This is a tiny bit more work for you, but down the road when someone who
is !tj is reviewing the logs, diffs, etc. it really helps to make the
substantive changes stand out.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FC81AE3.10304>