Date: Sun, 20 Nov 2005 13:45:41 -0800 From: Nate Lawson <nate@root.org> To: Lukas Ertl <le@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/vinum geom_vinum_rename.c Message-ID: <4380EE85.1040509@root.org> In-Reply-To: <20051120121247.873A316A45B@hub.freebsd.org> References: <20051120121247.873A316A45B@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Lukas Ertl wrote: > le 2005-11-20 12:12:31 UTC > > FreeBSD src repository > > Modified files: > sys/geom/vinum geom_vinum_rename.c > Log: > Always declare variables at the start of the function. > Don't allocate potentially large variables on the stack. > Check strsep() return values when the string comes from userland. > Shorten variable names for lucidity's sake. > > most of the stuff: > Pointed out by: njl@ > > Revision Changes Path > 1.2 +110 -47 src/sys/geom/vinum/geom_vinum_rename.c Excellent, thank you! -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4380EE85.1040509>