Date: Thu, 7 May 2009 12:48:10 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Jamie Gritton <jamie@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191898 - head/sys/compat/linux Message-ID: <eaa228be0905071248rd0f20d3p1e186fa9d9534f46@mail.gmail.com> In-Reply-To: <200905071946.n47JkTmQ066266@svn.freebsd.org> References: <200905071946.n47JkTmQ066266@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Worth remembering: the difference is not just that their sizes may (often do) differ. size_t is unsigned. ssize_t is signed. An unqualified int is signed. On Thu, May 7, 2009 at 12:46 PM, Jamie Gritton <jamie@freebsd.org> wrote: > Author: jamie > Date: Thu May 7 19:46:29 2009 > New Revision: 191898 > URL: http://svn.freebsd.org/changeset/base/191898 > > Log: > Give vfs_getopt the type it's expecting. > Write 100 times: "32 bits is so twentieth century." > > Noticed by: dchagin > > Modified: > head/sys/compat/linux/linux_mib.c > > Modified: head/sys/compat/linux/linux_mib.c > ============================================================================== > --- head/sys/compat/linux/linux_mib.c Thu May 7 19:17:06 2009 (r191897) > +++ head/sys/compat/linux/linux_mib.c Thu May 7 19:46:29 2009 (r191898) > @@ -223,8 +223,7 @@ linux_prison_check(void *obj __unused, v > { > struct vfsoptlist *opts = data; > char *osname, *osrelease; > - size_t len; > - int error, oss_version; > + int error, len, oss_version; > > /* Check that the parameters are correct. */ > (void)vfs_flagopt(opts, "linux", NULL, 0); > @@ -263,8 +262,7 @@ linux_prison_set(void *obj, void *data) > struct prison *pr = obj; > struct vfsoptlist *opts = data; > char *osname, *osrelease; > - size_t len; > - int error, gotversion, nolinux, oss_version, yeslinux; > + int error, gotversion, len, nolinux, oss_version, yeslinux; > > /* Set the parameters, which should be correct. */ > yeslinux = vfs_flagopt(opts, "linux", NULL, 0); >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eaa228be0905071248rd0f20d3p1e186fa9d9534f46>