Date: Tue, 24 Feb 2026 22:22:56 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Enji Cooper <ngie@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org> Subject: Re: git: 887f0f125fd1 - stable/14 - Revert "GoogleTest: import 1.17.0" Message-ID: <30C3C506-3327-4605-8D6C-237393D6D676@gmail.com> In-Reply-To: <db516db4-9741-4823-9b74-c69a13544e41@FreeBSD.org> References: <699a9186.32e99.543fe4bb@gitrepo.freebsd.org> <db516db4-9741-4823-9b74-c69a13544e41@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Feb 24, 2026, at 7:30 AM, John Baldwin <jhb@freebsd.org> wrote: > > On 2/22/26 00:17, Enji Cooper wrote: >> The branch stable/14 has been updated by ngie: >> URL: https://cgit.FreeBSD.org/src/commit/?id=887f0f125fd1282c8054b402ad72af371a9f5dec >> commit 887f0f125fd1282c8054b402ad72af371a9f5dec >> Author: Enji Cooper <ngie@FreeBSD.org> >> AuthorDate: 2026-02-22 05:17:40 +0000 >> Commit: Enji Cooper <ngie@FreeBSD.org> >> CommitDate: 2026-02-22 05:17:40 +0000 >> Revert "GoogleTest: import 1.17.0" >> This reverts commit 227baf32d26360137492b108aba06c6a54c0949b. > > Please include the "why" in commit logs when reverting. I (nor any > other readers) have any idea why you reverted these commits. Will do next time :/. I reverted these changes because some of the compiler changes made on main couldn’t be backported without potentially breaking how C++ binaries are built, resulting in potentially unexpected breakage on stable/14. I might retry it in a future cherry-pick after additional testing, but for now I pulled the changes out to ensure behavior isn’t dramatically changed on the branch. Thank you so very much for bringing this up. -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmelUAACgkQGpE5DjPs NJiZSQ//e1L8BZUMEbpjJHQLeZ1DNBrPNxghEjtHFs0gJlkWdSN4h1kdP79nBI0t 0B2IJ96nNk4+kW4JoWuGkgaGIlS2toshmtYj3ZC1/ZFaNqJoN4b0pvBDPjEuAvI6 RMQCtzne41riS2pCFth/X8cVua/mTIlyU34h5nwlykAHlaY0S3w9fYSe+YBx21DY HBG5zLBQKpKOo96+3OyguOCsv7jH72NMxdqPSjJTHtqPGThHw1IbaeQ2d3vQh6WB Vc28AkSBmhBFUpQu8T+SRFoM7IU3hxTIgLCTEQY7H+SRx3aF5jkQ2D/LfxYEK1ZS Uq6b6JQddWaPGp/DtcGUW/PWZ2cFUY7YI9zTnCGRNWqK4uPSX67SWooQFVRpuwZS Jm6J+IfdRn/rLTjG4UhKFV5YUR+6TlNALKSJdwxYEIQF+WQvqWYVq1vLwCirdI5Q 4NXq6nnI1v40zMbquBy3r0Mj1tNRnaY/5aRzISacscilfmauksobwNKk7v5IlacV Q7otjbGPoREOCxcgvnsnBLoPqfD/+l9kRrOVhhDiMRg3ATtw5QhvS2yqdYd5ql0e xjCy1azlHMW2iNIw/bECdjLYMLeYeQ7wbRtXlKXzms8n/W1Ests4sqkxAlPKn+/I dJGk7hvFZPThgDWzz2SiNEE+STumrrtGKQoNEtG/QpmtJnBw8jk= =h2lo -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30C3C506-3327-4605-8D6C-237393D6D676>