Date: Wed, 24 May 2017 20:53:01 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r318814 - head/cddl/contrib/opensolaris/lib/libzfs_core/common Message-ID: <201705242053.v4OKr1hK014752@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: avg Date: Wed May 24 20:53:01 2017 New Revision: 318814 URL: https://svnweb.freebsd.org/changeset/base/318814 Log: MFC r316904: 7729 libzfs_core`lzc_rollback() leaks result nvl illumos/illumos-gate@ac428481f96be89add7a1edf43ae47dd71038553 https://github.com/illumos/illumos-gate/commit/ac428481f96be89add7a1edf43ae47dd71038553 https://www.illumos.org/issues/7729 libzfs_core`lzc_rollback() doesn't free the result nvl after lzc_ioctl() call. Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Prakash Surya <prakash.surya@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com> Author: Yuri Pankov <yuri.pankov@nexenta.com> MFC after: 2 weeks Modified: head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c Directory Properties: head/cddl/contrib/opensolaris/ (props changed) Modified: head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c ============================================================================== --- head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c Wed May 24 20:52:47 2017 (r318813) +++ head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c Wed May 24 20:53:01 2017 (r318814) @@ -759,6 +759,8 @@ lzc_rollback(const char *fsname, char *s const char *snapname = fnvlist_lookup_string(result, "target"); (void) strlcpy(snapnamebuf, snapname, snapnamelen); } + nvlist_free(result); + return (err); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201705242053.v4OKr1hK014752>