Date: Tue, 18 Apr 2023 10:56:49 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org>, Gordon Bergling <gbe@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: <dee9d9ed-b84f-e3b5-edf3-e4ce7d5af236@FreeBSD.org> In-Reply-To: <ZD4/5ct2CICDmHX5@FreeBSD.org> References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> <ZD4044dQFqKchPYO@lion.ttyv0.de> <ZD4/5ct2CICDmHX5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/17/23 11:59 PM, Alexey Dokuchaev wrote: > On Tue, Apr 18, 2023 at 08:12:51AM +0200, Gordon Bergling wrote: >> On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: >>> On 18 Apr 2023, at 06:15, Gordon Bergling wrote: >> [...] >>>> --- a/stand/i386/boot0/Makefile >>>> +++ b/stand/i386/boot0/Makefile >>>> @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f >>>> # 0xb6 (182d) corresponds to 10 seconds. >>>> BOOT_BOOT0_TICKS?= 0xb6 >>>> >>>> -# The base address that we the boot0 code to to run it. Don't change this >>>> +# The base address that we the boot0 code to run it. Don't change this >>> >>> This was correct and is now incorrect; read as "that we [load] the >>> boot0 code to in order to run it". >> >> I just reverted the change. Sorry, not a native speaker on this side >> and the sentence was a little hard to understand. > > This reminds me of the situation with commit 8ca67bf1273 which jrtc27@ > pointed out was wrong, so I'd say again that comments like this should > be rephrased: these consequent double words make it hard to understand > and just begging for someone to try to "fix" it again in the future. Yes, I'll try to reword it. Gordon, your second change here was correct (the double "value") and you should go ahead and re-do that one. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dee9d9ed-b84f-e3b5-edf3-e4ce7d5af236>