Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Nov 1998 17:14:20 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        archie@whistle.com, grog@lemis.com, rnordier@nordier.com
Cc:        freebsd-current@FreeBSD.ORG
Subject:   Re: snprintf() in the kernel
Message-ID:  <199811210614.RAA24812@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>As promised, here are the patches to add [v]snprintf() to the kernel
>and fix a zillion occurrences of sprintf() and str[n]cpy()...
>
>  ftp://ftp.whistle.com/pub/archie/misc/SNPRINTF.patch.gz

It would have been easier to review if it were here:

>[here]

>There are 124 files affected.. so reviews are much appreciated!

snprintf returns a value which is almost always ignored.

Most of the strncpy -> snprintf changes are dubious, since
strncpy is often used for character arrays that aren't strings.
The changes for disk labels are certainly wrong.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811210614.RAA24812>