Date: Wed, 04 May 2005 18:23:23 +0200 From: Andre Oppermann <andre@freebsd.org> To: Max Laier <max@love2party.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/pf/net pf.c src/sys/netinetip_fastfwd.c ip_icmp.c ip_icmp.h ip_input.c Message-ID: <4278F6FB.42253A5E@freebsd.org> References: <200505041309.j44D9JUR051280@repoman.freebsd.org> <200505041747.39506.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Laier wrote: > > On Wednesday 04 May 2005 15:09, Andre Oppermann wrote: > > andre 2005-05-04 13:09:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/contrib/pf/net pf.c > > sys/netinet ip_fastfwd.c ip_icmp.c ip_icmp.h > > ip_input.c > > Log: > > Pass icmp_error() the MTU argument directly instead of > > an interface pointer. This simplifies a couple of uses > > and removes some XXX workarounds. > > src/MAINTAINERS: > > contrib/pf mlaier Pre-commit review requested. Sorry, I missed this line. > Sorry to be like this, but the above was: > 1) Incomplete > 2) A pain for future imports > > I'll fix it, but I can't see why you had to rush it in like this - without > testing. It not broken, compiles and works fine. No rushing it, had it in my tree for some time and went over it today. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4278F6FB.42253A5E>