Date: Mon, 30 May 2016 23:31:48 -0700 From: Xin Li <delphij@delphij.net> To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r301023 - head/sys/boot/geli Message-ID: <31d1323b-cb13-9a90-8b25-430fdbc1d225@delphij.net> In-Reply-To: <201605310624.u4V6OAYi071387@repo.freebsd.org> References: <201605310624.u4V6OAYi071387@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA Content-Type: multipart/mixed; boundary="8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai" From: Xin Li <delphij@delphij.net> To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net, Allan Jude <allanjude@freebsd.org> Message-ID: <31d1323b-cb13-9a90-8b25-430fdbc1d225@delphij.net> Subject: Re: svn commit: r301023 - head/sys/boot/geli References: <201605310624.u4V6OAYi071387@repo.freebsd.org> In-Reply-To: <201605310624.u4V6OAYi071387@repo.freebsd.org> --8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/30/16 23:24, Garrett Cooper wrote: > Author: ngie > Date: Tue May 31 06:24:09 2016 > New Revision: 301023 > URL: https://svnweb.freebsd.org/changeset/base/301023 >=20 > Log: > Add missing libc includes to fix -Wimplicit-function-declaration warn= ings > =20 > MFC after: 2 weeks > Reported by: clang > Sponsored by: EMC / Isilon Storage Division >=20 > Modified: > head/sys/boot/geli/geliboot_crypto.c >=20 > Modified: head/sys/boot/geli/geliboot_crypto.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:00:18 2016 (r301= 022) > +++ head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:24:09 2016 (r301= 023) > @@ -27,6 +27,10 @@ > * $FreeBSD$ > */ > =20 > +#include <stdio.h> > +#include <string.h> > +#include <strings.h> > + > #include "geliboot.h" This is wrong, you shouldn't use standard C library in freestanding environment. It seems that libstand.h is explicitly excluded, why? (in geliboot.h, allanjude cc'ed): %%% /* AES-XTS implementation */ #define _STAND #define STAND_H /* We don't want stand.h in {gpt,zfs,gptzfs}boot */ #include <opencrypto/xform_enc.h> %%% Cheers, --8c5pqQjh5u0PStkRWdp8Lrn6BXaVTitai-- --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIbBAEBCgAGBQJXTS/XAAoJEJW2GBstM+nsfNEP+Of3Td8mbIgcBHCfNlXaqHKy RVTckLPVP9eybJEH9L0FXORQC+jPNxWOlMp31s/Mr/3RgKzxSVypiTiLjWh9q6l1 p8CD4GrjkcqYAVcdw3cu7NS6HrAjKQkR0QJoZBNC2dX00DTtQYWudOzYCBxPZQC6 zr3f1+Pmo4jw9MB1/CIn1cxbhUUv5Txdz3yWfD1J/EVNoxQUvgVjEo/Dp3W/swcX T+e4E/paFFWddiTGpff9B9d6n8GE4PaRnsPIHVXLWkCbp7f4PuIlhBf56dls9yxQ ysrX5icZGpew4bQpaaYbn/SG9F0n6XuU/SdA5HTmtK4EaLZvmD38pc8WzW1AH+ey iHdhJC2F1r20jTPqPx8pdb5zZdNW3bPdDJ5Ouqsz537F13/99QH4yPK+nj0s52KF qpvGJMDHQHgGt/gE8OBlltqJb33khlc5Srulp1A7Wk6l7FDA5VG+JDucrVjvv0O0 xBf5KEuoKqSnb7YqgfS2Q6Hxf8MCmnoEBImZW05NnSjqI6N2lWl4ksu0ELkogdfP hVZBOSI976N6NzUa529/jzPSZosW6v8eyS7j3VL1DxvRqcMDvsTgTWBQ9gjNT1II OIimo9l6EpkilXySEVSXJf/rV1C5Q5XQukfTw1w+ZzsDH0+mm8cnm46xMsDWl7my WwFKWR500ubgzKKtxi4= =3XIz -----END PGP SIGNATURE----- --3KalNdK6TM0hUh0rgiuR2Bj2SpsJDWHNA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31d1323b-cb13-9a90-8b25-430fdbc1d225>