Date: Thu, 28 Jan 2021 09:51:32 +0200 From: Toomas Soome <tsoome@me.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: John Baldwin <jhb@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 6e26189be406 - main - Fix loader detection of vbefb support on !amd64 Message-ID: <2EA230CF-B642-456F-ACDA-150C016DAAAE@me.com> In-Reply-To: <B34BF8E8-5E72-418F-8C39-920D682F333C@FreeBSD.org> References: <202101272129.10RLTAee080408@gitrepo.freebsd.org> <3973a397-1250-1230-fecc-956b84c74fc9@FreeBSD.org> <B34BF8E8-5E72-418F-8C39-920D682F333C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 28. Jan 2021, at 09:50, Dimitry Andric <dim@FreeBSD.org> wrote: >=20 > On 28 Jan 2021, at 00:08, John Baldwin <jhb@FreeBSD.org> wrote: >>=20 >> On 1/27/21 1:29 PM, Dimitry Andric wrote: >>> The branch main has been updated by dim: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6e26189be406a9a3799074b16925e6cd= 63cc703b >>> commit 6e26189be406a9a3799074b16925e6cd63cc703b >>> Author: Dimitry Andric <dim@FreeBSD.org> >>> AuthorDate: 2021-01-27 21:28:43 +0000 >>> Commit: Dimitry Andric <dim@FreeBSD.org> >>> CommitDate: 2021-01-27 21:28:43 +0000 >>> Fix loader detection of vbefb support on !amd64 >>> On i386, after 6c7a932d0b8baaaee16eca0ba061bfa6e0e57bfd, the = vbefb vt >>> driver was no longer detected by the loader, if any kernel module = was >>> loaded after the kernel itself. >>> This was caused by the parse_vt_drv_set() function being = called multiple >>> times, resetting the detection flag. (It was called multiple = times, >>> becuase i386 .ko files are shared objects like the kernel proper, = while >>> this is not the case on amd64.) >>> Fix this by skipping the set_vt_drv_set lookup if vbefb was = already >>> detected. >>> Reviewed by: tsoome >>=20 >> Does the state get reset if you unload one kernel and then load a = different >> one (e.g. via interactive 'unload' and 'load /path/to/my/kernel')? >=20 > Ha, good one! I don't think it is. >=20 > -Dimitry >=20 I=E2=80=99m about to push it:) yes, it was missed. thanks, toomas=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2EA230CF-B642-456F-ACDA-150C016DAAAE>