Date: Mon, 19 Apr 2021 22:05:01 -0700 From: Kevin Bowling <kevin.bowling@kev009.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Pedro Giffuni <pfg@freebsd.org>, Dmitry Sivachenko <demon@freebsd.org>, Yuri <yuri@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d3ba089a5212 - main - Update to version 2.2.13. Message-ID: <CAK7dMtD-e8kd05EHTv3yHhv8iG2iGJseU=FpqnMvifAiaMUvMQ@mail.gmail.com> In-Reply-To: <202104200324.13K3OOwj010751@slippy.cwsent.com> References: <202104192213.13JMDlRd039737@gitrepo.freebsd.org> <a3ff4614-b99a-f64f-b9d2-0b71c2f82f5d@rawbw.com> <A14E4A66-FEB3-4E41-B413-8413D479EF89@FreeBSD.org> <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org> <202104200324.13K3OOwj010751@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'd like to see something for "Change URL:" or "Change Log:" too, currently some people add this but there seems to be no consistency. Since there isn't a common standard, I usually add it in the commit body as text so as not to imply structure someone might rely on in scripts, web UIs, etc... "changes //:url/" On Mon, Apr 19, 2021 at 8:24 PM Cy Schubert <Cy.Schubert@cschubert.com> wrote: > > In message <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org>, Pedro Giffuni wr > ites: > > On 19/04/2021 17:24, Dmitry Sivachenko wrote: > > > > > >> On 20 Apr 2021, at 01:17, Yuri <yuri@FreeBSD.org> wrote: > > >> > > >> On 4/19/21 3:13 PM, Dmitry Sivachenko wrote: > > >>> Update to version 2.2.13. > > >> > > >> Why didn't you mention in the commit message what port was updated? > > >> net/haproxy is one of thousands of ports and having a message like this do > > esn't help to understand what the change is. > > >> > > > Hello, > > > > > > what do you mean 'what port was updated'? It is clean from the commit log > > that it is net/haproxy that was updated, only two files changed: > > > Update to version 2.2.13. > > > > It is not a all "clean" if you do: > > > > git log --oneline > > This is a systemic problem that probably needs to be addressed sooner than later. > An aid like a .gitmessage might help. To help me remember I used this: > > # component (like category/port or bin/cat): Title line goes here > > # A paragraph or more to discuss the change. > > PR: > Submitted by: > Reported by: > Reviewed by: > Approved by: > Obtained from: > MFC after: > MFH: > Relnotes: > Security: > Sponsored by: > Differential Revision: > #--This line, and those below, will be ignored-- > # Description of fields to fill in above: 76 columns --| > # PR: If and which Problem Report is related. > # Submitted by: If someone else sent in the change. > # Reported by: If someone else reported the issue. > # Reviewed by: If someone else reviewed your modification. > # Tested by: If someone else tested the change. > # Approved by: If you needed approval for this commit. > # Obtained from: If the change is from a third party. > # MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email. > # MFH: Ports tree branch name. Request approval for merge. > # Relnotes: Set to 'yes' for mention in release notes. > # Security: Vulnerability reference (one per line) or description. > # Sponsored by: If the change was sponsored by an organization. > # Differential Revision: https://reviews.freebsd.org/D### (*full* phabric URL needed). > # Empty fields above will be automatically removed. > > > Replacing the first two comments with a title line and a short paragraph, filling in the fields as needed, discarding the rest. > > This, https://chris.beams.io/posts/git-commit/, is a good read. > > Old habits die hard. Someone reached out to me in January but the .gitmessage template helped me a lot. Unlearning old habits is harder than learning new ones. > > > -- > Cheers, > Cy Schubert <Cy.Schubert@cschubert.com> > FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org > NTP: <cy@nwtime.org> Web: https://nwtime.org > > The need of the many outweighs the greed of the few. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK7dMtD-e8kd05EHTv3yHhv8iG2iGJseU=FpqnMvifAiaMUvMQ>