Date: Thu, 6 Jan 2011 10:09:59 +0100 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= <trasz@freebsd.org> To: Julian Elischer <julian@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217048 - head/share/man/man9 Message-ID: <8C6A03B3-8A1E-4316-8A7C-1EF4CE10E12B@freebsd.org> In-Reply-To: <4D258533.3@freebsd.org> References: <201101060833.p068Xmrj008299@svn.freebsd.org> <4D258533.3@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Wiadomość napisana przez Julian Elischer w dniu 2011-01-06, o godz. 10:02: > On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Thu Jan 6 08:33:48 2011 >> New Revision: 217048 >> URL: http://svn.freebsd.org/changeset/base/217048 >> >> Log: >> Get rid of bad advice regarding /* NOTREACHED */. Compilers don't >> really need it (one can use __dead2 instead), and style(9) was not >> even consistent with itself in this regard. >> >> Modified: >> head/share/man/man9/style.9 >> >> Modified: head/share/man/man9/style.9 >> ============================================================================== >> --- head/share/man/man9/style.9 Thu Jan 6 08:13:30 2011 (r217047) >> +++ head/share/man/man9/style.9 Thu Jan 6 08:33:48 2011 (r217048) >> @@ -470,9 +470,6 @@ statement that cascade should have a >> .Li FALLTHROUGH >> comment. >> Numerical arguments should be checked for accuracy. >> -Code that cannot be reached should have a >> -.Li NOTREACHED >> -comment. > > I object STRONGLY to this change. > > The NOTREACHED is also to help the reader understand what has happened and as an afterthought > was also useful in LINT. I know know of no technological change to the average reader that makes > it less useful. What about adding something like this? Code that cannot be reached for non-obvious reasons may have .Li NOTREACHED comment. -- If you cut off my head, what would I say? Me and my head, or me and my body?help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8C6A03B3-8A1E-4316-8A7C-1EF4CE10E12B>