Date: Thu, 12 Mar 1998 12:52:03 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, cracauer@cons.org Cc: freebsd-current@FreeBSD.ORG Subject: Re: make/SIGINT (Re: cvs commit: src/bin/sh jobs.c) Message-ID: <199803120152.MAA09328@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>What about the appended fix for make? It seems to fix the problem for >the non-compat mode of make. As our make is in compat mode by default >even if -B is not given, people would have to use `make -j 1` for now >to test it. > >What were the reasons to use compat mode by default, BTW? Anyone has >test cases that fail in new mode with just one job allowed? Compatibility? :-) >diff -c make.original/job.c make.work/job.c >*** make.original/job.c Tue Aug 26 12:06:38 1997 >--- make.work/job.c Wed Mar 11 12:49:52 1998 >*************** >*** 2904,2910 **** > } > } > (void) eunlink(tfile); >! exit(signo); > } > > /* >--- 2904,2918 ---- > } > } > (void) eunlink(tfile); >! >! /* >! * For some signals, we don't want a direct exit, but to >! * let them resent to ourself, which is done by the calling >! * Routine. >! */ >! >! if (signo != SIGINT && signo != SIGTERM && signo != SIGHUP) >! exit(signo); > } > > /* I just removed the exit() in my version. This seems to be what was intended, and seems to work. I thought that the fix was necessary for compat mode too. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803120152.MAA09328>