Date: Fri, 11 May 2012 16:08:54 -0400 From: Warner Losh <imp@bsdimp.com> To: Colin Percival <cperciva@FreeBSD.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Gabor Kovesdan <gabor@FreeBSD.org> Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls Message-ID: <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com> In-Reply-To: <4FAD0DF4.9000609@freebsd.org> References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> <4FAD0DF4.9000609@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 11, 2012, at 9:02 AM, Colin Percival wrote: > On 05/11/12 05:48, Konstantin Belousov wrote: >> On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >>> +bool byte_sort =3D false; + +static wchar_t **wmonths =3D NULL; = +static >>> unsigned char **cmonths =3D NULL; >>=20 >> Such initializations are useless. You only increase the size of the = binary=20 >> on the disk as the consequence. >=20 > I just tested this hypothesis, and found no change in binary size = using > either clang or gcc46. Presumably they're smart enough to ignore = explicit > (and unnecessary) initializations of statics to zero. How did you test this? size(1) or ls(1)? If ls, then you may be = running into the page rounding of the .text and .data sections... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9>