Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jan 2009 13:39:02 +0000 (UTC)
From:      Luigi Rizzo <luigi@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r187822 - head/sys/netinet
Message-ID:  <200901281339.n0SDd2Bb021996@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: luigi
Date: Wed Jan 28 13:39:01 2009
New Revision: 187822
URL: http://svn.freebsd.org/changeset/base/187822

Log:
  initialize a couple of variables, gcc 4.2.4-4 (linux) reports
  some possible uninitialized uses and the warning does make sense.

Modified:
  head/sys/netinet/ip_fw2.c

Modified: head/sys/netinet/ip_fw2.c
==============================================================================
--- head/sys/netinet/ip_fw2.c	Wed Jan 28 13:11:22 2009	(r187821)
+++ head/sys/netinet/ip_fw2.c	Wed Jan 28 13:39:01 2009	(r187822)
@@ -2254,6 +2254,7 @@ ipfw_chk(struct ip_fw_args *args)
 	if (m->m_flags & M_SKIP_FIREWALL)
 		return (IP_FW_PASS);	/* accept */
 
+	dst_ip.s_addr = 0;		/* make sure it is initialized */
 	pktlen = m->m_pkthdr.len;
 	args->f_id.fib = M_GETFIB(m); /* note mbuf not altered) */
 	proto = args->f_id.proto = 0;	/* mark f_id invalid */
@@ -2711,7 +2712,7 @@ check_body:
 				    uint32_t a =
 					(cmd->opcode == O_IP_DST_LOOKUP) ?
 					    dst_ip.s_addr : src_ip.s_addr;
-				    uint32_t v;
+				    uint32_t v = 0;
 
 				    match = lookup_table(chain, cmd->arg1, a,
 					&v);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901281339.n0SDd2Bb021996>