Date: Tue, 21 Jan 2003 15:43:16 -0800 From: "Sam Leffler" <sam@errno.com> To: "Marcel Moolenaar" <marcel@xcllnt.net>, "M. Warner Losh" <imp@bsdimp.com> Cc: <arch@FreeBSD.ORG> Subject: Re: Alfre's malloc changes: the next step Message-ID: <072501c2c1a6$df798450$52557f42@errno.com> References: <20030121.144243.52206100.imp@bsdimp.com> <20030121224024.GA1095@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, Jan 21, 2003 at 02:42:43PM -0700, M. Warner Losh wrote:
> > In IRC there's much concern over alfred's changes from a cross os
> > portability standpoint, as well as a SMP standpoint. I'd like to
> > propose that we do something like the following:
> [snip]
> > 4) We back out the bulk of the changes made, except where they were
> > real bugs.
> [snip]
> >
> > Comments?
>
> I tend to prefer a backout as the first step if we like to clean
> up the M_*WAIT* stuff in a different way. Not reverting first
> may result in bugs that we're introduced by the first makeover,
> and then subsequently hidden by the second makeover. I don't
> say there are any bugs, just that in the case of there being
> bugs this could happen.
I prefer this too. This commit should never have been done w/o review.
OTOH I understand what an incredible PITA it is to back out this muck and
your patch will probably have to be done. Sigh.
Sam
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?072501c2c1a6$df798450$52557f42>