Date: Tue, 16 Feb 2021 18:11:09 +0000 From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 253521] bhyve crash with e1000 emulation Message-ID: <bug-253521-27103-UQXoftVML9@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253521-27103@https.bugs.freebsd.org/bugzilla/> References: <bug-253521-27103@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253521 --- Comment #1 from sigsys@gmail.com --- Patch is wrong. There's a check further down for iovcnt being too high. It crashed again. The problem must be something else. I added an assert to check for paddr_guest2host() returning NULL and it got triggered. This probably would have caused a crash later on. diff --git i/usr.sbin/bhyve/pci_e82545.c w/usr.sbin/bhyve/pci_e82545.c index dca981be85fa..61f6ed69c072 100644 --- i/usr.sbin/bhyve/pci_e82545.c +++ w/usr.sbin/bhyve/pci_e82545.c @@ -1152,6 +1152,7 @@ e82545_transmit(struct e82545_softc *sc, uint16_t hea= d, uint16_t tail, iov[iovcnt].iov_base =3D paddr_guest2host( sc->esc_ctx, dsc->td.buffer_addr, len); iov[iovcnt].iov_len =3D len; + assert(iov[iovcnt].iov_base !=3D NULL); } iovcnt++; } --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253521-27103-UQXoftVML9>