Date: Thu, 22 Jul 2010 22:34:45 +0200 From: Dimitry Andric <dimitry@andric.com> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: svn commit: r210384 - head/sys/conf Message-ID: <4C48AB65.1030207@andric.com> In-Reply-To: <201007221614.11334.jkim@FreeBSD.org> References: <201007221847.o6MIlfxH030805@svn.freebsd.org> <201007221614.11334.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 2010-07-22 22:13, Jung-uk Kim wrote:
>> CFLAGS= ${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
>> CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
>> -include opt_global.h -.if ${CC} != "icc"
>> +.if ${CC} != "icc" && ${CC} != "clang"
>> CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
>> .if ${MACHINE_CPUARCH} != "mips"
>> CFLAGS+= --param inline-unit-growth=100
>
> Isn't it little premature to remove -Werror from clang?
Yes, probably. Please consider the attached patch, which only rubs out
the compilation options that clang does not support.
[-- Attachment #2 --]
diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk
index 5c22abd..7642fca 100644
--- a/sys/conf/kern.pre.mk
+++ b/sys/conf/kern.pre.mk
@@ -92,7 +92,8 @@ INCLUDES+= -I$S/dev/cxgb
CFLAGS= ${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h
-.if ${CC} != "icc" && ${CC} != "clang"
+.if ${CC} != "icc"
+.if ${CC} != "clang"
CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
.if ${MACHINE_CPUARCH} != "mips"
CFLAGS+= --param inline-unit-growth=100
@@ -102,6 +103,7 @@ CFLAGS+= --param large-function-growth=1000
CFLAGS+= --param inline-unit-growth=1000
CFLAGS+= --param large-function-growth=100000
.endif
+.endif
WERROR?= -Werror
.endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C48AB65.1030207>