Date: Fri, 3 Mar 2006 22:48:19 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jeff Roberson <jeff@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vfs.c Message-ID: <20060303214819.GB11030@garage.freebsd.pl> In-Reply-To: <200603020537.k225bi8G006318@repoman.freebsd.org> References: <200603020537.k225bi8G006318@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 02, 2006 at 05:37:44AM +0000, Jeff Roberson wrote: +> jeff 2006-03-02 05:37:44 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/geom geom_vfs.c=20 +> Log: +> - Lock Giant if needed around the call to vnode_create_vobject(). Th= is is +> only important if devfs is not mpsafe. [...] +> g_topology_assert(); +> @@ -147,7 +148,9 @@ g_vfs_open(struct vnode *vp, struct g_co +> g_wither_geom(gp, ENXIO); +> return (error); +> } +> + vfslocked =3D VFS_LOCK_GIANT(vp->v_mount); +> vnode_create_vobject(vp, pp->mediasize, curthread); +> + VFS_UNLOCK_GIANT(vfslocked); Acquiring Giant while holding the topology lock is a bad thing, AFAIK. CCing phk@ to correct me if I'm wrong or explain why exactly I'm right. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFECLmjForvXbEpPzQRApjTAJ9uFBdWx9cygKU7/X5nAvABgvtE9ACfSGJU 30YFh8vrUmAKNVldLQfRYjw= =3xbU -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060303214819.GB11030>