Date: Tue, 28 Mar 2006 20:30:20 GMT From: "Devon H. O'Dell" <devon.odell@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades Message-ID: <200603282030.k2SKUKxW013635@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/94939; it has been noted by GNATS. From: "Devon H. O'Dell" <devon.odell@gmail.com> To: "Nate Lawson" <nate@root.org> Cc: "John Baldwin" <jhb@freebsd.org>, bug-followup@freebsd.org Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades Date: Tue, 28 Mar 2006 12:21:00 -0800 ------=_Part_3258_17872550.1143577260091 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline > The patch has some other major problems that should be addressed before > committing. It should not manually be parsing the GAS and mapping > memory etc. Instead, it should just use AcpiHwLowLevelWrite(): > > ACPI_STATUS > AcpiHwLowLevelWrite ( > UINT32 Width, > UINT32 Value, > ACPI_GENERIC_ADDRESS *Reg); > > Width should be 8, value should be the reset value in the FADT, and Reg > should be the FADT GAS struct. Please see http://www.sitetronics.com/~dodell/acpi2.diff (also attached). This addresses this issue and significantly reduces the size of the diff :) --Devon ------=_Part_3258_17872550.1143577260091 Content-Type: application/octet-stream; name="acpi2.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="acpi2.diff" SW5kZXg6IHN5cy9kZXYvYWNwaWNhL2FjcGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9k b2RlbGwvY3ZzL3NyYy9zeXMvZGV2L2FjcGljYS9hY3BpLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuMjE5CmRpZmYgLXUgLXIxLjIxOSBhY3BpLmMKLS0tIHN5cy9kZXYvYWNwaWNhL2FjcGkuYwk3 IE5vdiAyMDA1IDIxOjUyOjA2IC0wMDAwCTEuMjE5CisrKyBzeXMvZGV2L2FjcGljYS9hY3BpLmMJ MjggTWFyIDIwMDYgMjA6MDY6MTUgLTAwMDAKQEAgLTE2MzYsNiArMTYzNiwxNiBAQAogCSAgICBE RUxBWSgxMDAwMDAwKTsKIAkgICAgcHJpbnRmKCJBQ1BJIHBvd2VyLW9mZiBmYWlsZWQgLSB0aW1l b3V0XG4iKTsKIAl9CisgICAgfSBlbHNlIGlmICgoaG93dG8gJiBSQl9BVVRPQk9PVCkgIT0gMCAm JiBBY3BpR2JsX0ZBRFQtPlJlc2V0UmVnU3VwKSB7CisJc3RhdHVzID0gQWNwaUh3TG93TGV2ZWxX cml0ZSg4LCBBY3BpR2JsX0ZBRFQtPlJlc2V0VmFsdWUsCisJICAgIEFjcGlHYmxfRkFEVC0+UmVz ZXRSZWdpc3Rlcik7CisKKwlpZiAoQUNQSV9GQUlMVVJFKHN0YXR1cykpIHsKKwkgICAgcHJpbnRm KCJBQ1BJIHJlc2V0IGZhaWxlZCAtICVzXG4iLCBBY3BpRm9ybWF0RXhjZXB0aW9uKHN0YXR1cykp OworCX0gZWxzZSB7CisJICAgIERFTEFZKDEwMDAwMDApOworCSAgICBwcmludGYoIkFDUEkgcmVz ZXQgZmFpbGVkIC0gdGltZW91dFxuIik7CisJfQogICAgIH0gZWxzZSBpZiAocGFuaWNzdHIgPT0g TlVMTCkgewogCXByaW50ZigiU2h1dHRpbmcgZG93biBBQ1BJXG4iKTsKIAlBY3BpVGVybWluYXRl KCk7Cg== ------=_Part_3258_17872550.1143577260091--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603282030.k2SKUKxW013635>