Date: Sun, 20 Jul 2014 13:31:24 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, Tijl Coosemans <tijl@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140720113124.GD26778@ivaldir.etoilebsd.net> In-Reply-To: <53CBA770.2010409@marino.st> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--8nsIa27JVQLqB7/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: > On 7/20/2014 13:22, Tijl Coosemans wrote: > > On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: > >> Author: marino > >> Date: Sun Jul 20 08:15:16 2014 > >> New Revision: 362304 > >> URL: http://svnweb.freebsd.org/changeset/ports/362304 > >> QAT: https://qat.redports.org/buildarchive/r362304/ > >> > >> Log: > >> x11-toolkits/pango: require explicit linking > >> =20 > >> This new configure argument will list all required libraries in the > >> generated pkgconf files. Before any library indirectly pulled in, s= uch > >> as libm, was not listed. > >> =20 > >> This fixes numerous regression in dports and it's more correct anywa= y. > >=20 > > No, this is wrong. Each port should link to the libraries it needs on > > its own. No port should rely on other ports to pull in libraries for > > them. >=20 > Then I guess we really don't need pkgconfig .pc files at all then? > (This is the point of .pc files, it tells how to link. libm is directly > used by pango) >=20 > so no, it is not wrong. The generated pc file was wrong, now it's not. > This is why the configuration argument exists. >=20 The good question is "does pango exposes parts of libm or not?" if yes then= libm should be listed in the libraries of pango.pc is not it should only appears= in the private field. regards, Bapt --8nsIa27JVQLqB7/C Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPLqIwACgkQ8kTtMUmk6EzxOgCfYkYt1YtkSF59uv/IxOYXGCUA vVcAoLZR/E61FPAxS8kKfI3hGk0C2nS+ =s+qN -----END PGP SIGNATURE----- --8nsIa27JVQLqB7/C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140720113124.GD26778>