Date: Mon, 16 Jan 2023 15:13:37 -0700 From: Adam Weinberger <adamw@adamw.org> To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>, jaap@nlnetlabs.nl Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option Message-ID: <CAP7rwci4NT5N5dPbdqgVHYDaM8H%2BoydOv6x72JHKY4GdQk5Hzg@mail.gmail.com> In-Reply-To: <CAGwOe2aEY9ok_B-Tc2GeX8jDkXvjhrjNck7kLJ4pnbaWz1DMQw@mail.gmail.com> References: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> <CAP7rwcgBQD3oQJRKyvjposA=WW1%2BJku7Xzv_mF2-rcwJy-eqdg@mail.gmail.com> <CAGwOe2aEY9ok_B-Tc2GeX8jDkXvjhrjNck7kLJ4pnbaWz1DMQw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jan 16, 2023 at 2:12 PM Fernando Apesteguía <fernape@freebsd.org> wrote: > > > El lun., 16 ene. 2023 19:50, Adam Weinberger <adamw@adamw.org> escribió: > >> >> >> On Mon, Jan 16, 2023 at 5:48 AM Fernando Apesteguía <fernape@freebsd.org> >> wrote: >> >>> The branch main has been updated by fernape: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> >>> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> Author: Fernando Apesteguía <fernape@FreeBSD.org> >>> AuthorDate: 2023-01-15 19:29:38 +0000 >>> Commit: Fernando Apesteguía <fernape@FreeBSD.org> >>> CommitDate: 2023-01-16 12:44:02 +0000 >>> >>> dns/unbound: add dynlib port option >>> >> >>> PR: 268942 >>> Reported by: me@rcm.sh >>> Approved by: jaap@NLnetLabs.nl (maintainer) >>> --- >>> dns/unbound/Makefile | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> >> Does this need a pkg-plist change? If the plist is the same with this >> option on and off, what is this option actually controlling? >> > > The dynlib option is to build that module into the same daemon: > > > https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dynamic-library-module-options > Ohhhh, so it's about loading *third-party* modules as shared libs? (Looping in maintainer here) If the previous statement is correct, would you be okay with me updating DYNLIB_DESC to reflect that? As it's currently written it looks like turning it off would create a fully statically-linked sbin/unbound, which is not the case. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 16, 2023 at 2:12 PM Fernando Apesteguía <<a href="mailto:fernape@freebsd.org">fernape@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El lun., 16 ene. 2023 19:50, Adam Weinberger <<a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 16, 2023 at 5:48 AM Fernando Apesteguía <<a href="mailto:fernape@freebsd.org" rel="noreferrer" target="_blank">fernape@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by fernape:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=38e6e935efa67110ba6d2d1e322555f0afbb8383" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=38e6e935efa67110ba6d2d1e322555f0afbb8383</a><br>; <br> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383<br> Author: Fernando Apesteguía <fernape@FreeBSD.org><br> AuthorDate: 2023-01-15 19:29:38 +0000<br> Commit: Fernando Apesteguía <fernape@FreeBSD.org><br> CommitDate: 2023-01-16 12:44:02 +0000<br> <br> dns/unbound: add dynlib port option <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> PR: 268942<br> Reported by: <a href="mailto:me@rcm.sh" rel="noreferrer" target="_blank">me@rcm.sh</a><br> Approved by: jaap@NLnetLabs.nl (maintainer)<br> ---<br> dns/unbound/Makefile | 9 ++++++---<br> 1 file changed, 6 insertions(+), 3 deletions(-)<br> <br></blockquote><div><br></div><div style="font-family:arial,sans-serif">Does this need a pkg-plist change? If the plist is the same with this option on and off, what is this option actually controlling?</div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">The dynlib option is to build that module into the same daemon:</div><div dir="auto"><br></div><div dir="auto"><a href="https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dynamic-library-module-options" target="_blank">https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dynamic-library-module-options</a><br></div></div></blockquote><div><br></div></div><div style="font-family:arial,sans-serif" class="gmail_default">Ohhhh, so it's about loading *third-party* modules as shared libs?</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">(Looping in maintainer here) If the previous statement is correct, would you be okay with me updating DYNLIB_DESC to reflect that? As it's currently written it looks like turning it off would create a fully statically-linked sbin/unbound, which is not the case.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default"># Adam<br></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Adam Weinberger</div><div><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a></div><div><a href="https://www.adamw.org" target="_blank">https://www.adamw.org</a></div></div></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwci4NT5N5dPbdqgVHYDaM8H%2BoydOv6x72JHKY4GdQk5Hzg>