Date: Tue, 03 Sep 2019 14:06:08 -0000 From: Enji Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs Message-ID: <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> In-Reply-To: <201904021844.x32Ii1wR041319@repo.freebsd.org> References: <201904021844.x32Ii1wR041319@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 2, 2019, at 11:44 AM, Alan Somers <asomers@FreeBSD.org> wrote: > > Author: asomers > Date: Tue Apr 2 18:44:01 2019 > New Revision: 345809 > URL: https://svnweb.freebsd.org/changeset/base/345809 > > Log: > fusefs: check return value of wait(2) in fork tests > > Reported by: ngie > Sponsored by: The FreeBSD Foundation > > Modified: > projects/fuse2/tests/sys/fs/fusefs/utils.cc > > Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc > ============================================================================== > --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:09:40 2019 (r345808) > +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:44:01 2019 (r345809) > @@ -321,7 +321,7 @@ out: > /* Signal the child process to go */ > ASSERT_EQ(0, sem_post(sem)) << strerror(errno); > > - wait(&child_status); > + ASSERT_LE(0, wait(&child_status)) << strerror(errno); Don’t you want ASSERT_GE here, since you’re testing that wait succeeded? -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?77D06D49-8CE8-483C-90FF-D8CD0122599E>