Date: Fri, 25 Jun 1999 13:40:23 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Guido van Rooij <guido@gvr.org> Cc: Julian Elischer <julian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/nfs nfs_serv.c nfs_subs.c nfs_syscalls.c nfsm_subs.h Message-ID: <199906252040.NAA95051@apollo.backplane.com> References: <199906230444.VAA96892@freefall.freebsd.org> <19990623163330.A11603@gvr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:On Tue, Jun 22, 1999 at 09:44:17PM -0700, Julian Elischer wrote:
:> julian 1999/06/22 21:44:16 PDT
:>
:> Modified files:
:> sys/nfs nfs_serv.c nfs_subs.c nfs_syscalls.c
:> nfsm_subs.h
:> Log:
:> Matt's NFS fixes.
:> Submitted by: Matt Dillon
:> Reviewed by: David Cross, Julian Elischer, Mike Smith, Drew Gallatin
:> 3.2 version to follow when tested
:
:Is there a more verbose description on exactly what was fixed?
:
:-Guido
A couple of things ( Julian, you should commit a followup log entry ):
* David Cross found a bug in nfs_serv.c/nfsrv_create()
* I went through all of nfs_serv.c and fixed the bug Dave Found, but
found lots of bugs in dealing with error conditions. ( If no errors
occured, only the bug Dave found would be hit ). The problems were
mainly related to code cleanup due to goto's in nfsm*() macros.
This is what the vast majority of the patch deals with.
* A number of serious issues with the namei() code were found. These
aren't bugs, but instead related to fields that namei invalidates but
fails to NULL-out which, in-turn, creates a massive cleanup hassle
for just about every piece of code that calls namei() or lookup().
No fixes have been made to these routines yet.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199906252040.NAA95051>