Date: Sun, 16 Mar 2003 21:25:34 -0800 From: Alfred Perlstein <bright@mu.org> To: sam@freebsd.org Cc: imp@freebsd.org, current@freebsd.org Subject: Re: wi driver Message-ID: <20030317052534.GO4145@elvis.mu.org> In-Reply-To: <20030317051920.GN4145@elvis.mu.org> References: <20030317051920.GN4145@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alfred Perlstein <bright@mu.org> [030316 21:19] wrote:
> um..
>
...
840 _FLAGS_OUTRANGE) {
841 WI_UNLOCK(sc);
842 return;
843 }
844 KASSERT((ifp->if_flags & IFF_OACTIVE) == 0,
845 ("wi_start: if_flags %x\n", ifp->if_flags));
846
847 memset(&frmhdr, 0, sizeof(frmhdr));
>
> What's up here?
It's a race, we shouldn't be inspecting the ifp without a lock.
I think this kassert should be removed.
Do you guys concurr?
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030317052534.GO4145>