Date: Wed, 5 Apr 2017 14:33:35 -0500 From: Kyle Evans <kevans91@ksu.edu> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Ed Maste <emaste@freebsd.org>, <svn-src-head@freebsd.org>, <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r316536 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep/tests Message-ID: <CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw@mail.gmail.com> In-Reply-To: <85B65B02-8146-449C-B003-B375B8EE3F43@gmail.com> References: <201704051841.v35IfiP2009466@repo.freebsd.org> <85B65B02-8146-449C-B003-B375B8EE3F43@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a1149200c42b581054c707979
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, Apr 5, 2017 at 1:48 PM, Ngie Cooper (yaneurabeya) <
yaneurabeya@gmail.com> wrote:
>
> As a general rule of thumb, if it doesn=E2=80=99t pass, it needs =
to be
> marked as an expected failure until it passes. Not really a big deal righ=
t
> now (because ci.freebsd.org isn=E2=80=99t spamming current@ =E2=80=94 yet=
), but when that
> switch gets thrown again, it would spam a few hundred people with known
> failures.
>
Ah, whoops. Something like this?
diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
index b8d2a398c8d..189e3547e34 100755
--- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
+++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
@@ -234,6 +234,7 @@ oflag_zerolen_head()
}
oflag_zerolen_body()
{
+ atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs
(PR 195763)"
atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
@@ -281,6 +282,7 @@ color_body()
atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
grep --color=3Dauto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
+ atf_expect_fail "GNU grep --color output does not exactly match
expectations going forward"
atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
grep --color=3Dalways -f grepfile "$(atf_get_srcdir)/d_color_b.in"
}
--001a1149200c42b581054c707979
Content-Type: text/plain; charset="US-ASCII"; name="grep-fail-tests.diff"
Content-Disposition: attachment; filename="grep-fail-tests.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_j15de42u1
ZGlmZiAtLWdpdCBhL2NvbnRyaWIvbmV0YnNkLXRlc3RzL3Vzci5iaW4vZ3JlcC90X2dyZXAuc2gg
Yi9jb250cmliL25ldGJzZC10ZXN0cy91c3IuYmluL2dyZXAvdF9ncmVwLnNoCmluZGV4IGI4ZDJh
Mzk4YzhkLi4xODllMzU0N2UzNCAxMDA3NTUKLS0tIGEvY29udHJpYi9uZXRic2QtdGVzdHMvdXNy
LmJpbi9ncmVwL3RfZ3JlcC5zaAorKysgYi9jb250cmliL25ldGJzZC10ZXN0cy91c3IuYmluL2dy
ZXAvdF9ncmVwLnNoCkBAIC0yMzQsNiArMjM0LDcgQEAgb2ZsYWdfemVyb2xlbl9oZWFkKCkKIH0K
IG9mbGFnX3plcm9sZW5fYm9keSgpCiB7CisJYXRmX2V4cGVjdF9mYWlsICJHTlUgZ3JlcCdzIC1v
IGJlaGF2aW9yIHdpdGggZW1wdHkgbWF0Y2hlcyBoYXMga25vd24gYnVncyAoUFIgMTk1NzYzKSIK
IAlhdGZfY2hlY2sgLW8gZmlsZToiJChhdGZfZ2V0X3NyY2RpcikvZF9vZmxhZ196ZXJvbGVuX2Eu
b3V0IiBcCiAJICAgIGdyZXAgLUVvICcoXnw6KTAqJyAiJChhdGZfZ2V0X3NyY2RpcikvZF9vZmxh
Z196ZXJvbGVuX2EuaW4iCiAKQEAgLTI4MSw2ICsyODIsNyBAQCBjb2xvcl9ib2R5KCkKIAlhdGZf
Y2hlY2sgLW8gZmlsZToiJChhdGZfZ2V0X3NyY2RpcikvZF9jb2xvcl9iLm91dCIgXAogCSAgICBn
cmVwIC0tY29sb3I9YXV0byAtZiBncmVwZmlsZSAiJChhdGZfZ2V0X3NyY2RpcikvZF9jb2xvcl9i
LmluIgogCisJYXRmX2V4cGVjdF9mYWlsICJHTlUgZ3JlcCAtLWNvbG9yIG91dHB1dCBkb2VzIG5v
dCBleGFjdGx5IG1hdGNoIEJTRCBncmVwJ3MiCiAJYXRmX2NoZWNrIC1vIGZpbGU6IiQoYXRmX2dl
dF9zcmNkaXIpL2RfY29sb3JfYy5vdXQiIFwKIAkgICAgZ3JlcCAtLWNvbG9yPWFsd2F5cyAtZiBn
cmVwZmlsZSAiJChhdGZfZ2V0X3NyY2RpcikvZF9jb2xvcl9iLmluIgogfQo=
--001a1149200c42b581054c707979--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw>