Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 5 Apr 2017 14:33:35 -0500
From:      Kyle Evans <kevans91@ksu.edu>
To:        "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Cc:        Ed Maste <emaste@freebsd.org>, <svn-src-head@freebsd.org>, <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>
Subject:   Re: svn commit: r316536 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep/tests
Message-ID:  <CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw@mail.gmail.com>
In-Reply-To: <85B65B02-8146-449C-B003-B375B8EE3F43@gmail.com>
References:  <201704051841.v35IfiP2009466@repo.freebsd.org> <85B65B02-8146-449C-B003-B375B8EE3F43@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help 

[-- Attachment #1 --]
On Wed, Apr 5, 2017 at 1:48 PM, Ngie Cooper (yaneurabeya) <
yaneurabeya@gmail.com> wrote:

>
>         As a general rule of thumb, if it doesn’t pass, it needs to be
> marked as an expected failure until it passes. Not really a big deal right
> now (because ci.freebsd.org isn’t spamming current@ — yet), but when that
> switch gets thrown again, it would spam a few hundred people with known
> failures.
>

Ah, whoops. Something like this?

 diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
index b8d2a398c8d..189e3547e34 100755
--- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
+++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
@@ -234,6 +234,7 @@ oflag_zerolen_head()
 }
 oflag_zerolen_body()
 {
+ atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs
(PR 195763)"
  atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
     grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"

@@ -281,6 +282,7 @@ color_body()
  atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
     grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"

+ atf_expect_fail "GNU grep --color output does not exactly match
expectations going forward"
  atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
     grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
 }

[-- Attachment #2 --]
diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
index b8d2a398c8d..189e3547e34 100755
--- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
+++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
@@ -234,6 +234,7 @@ oflag_zerolen_head()
 }
 oflag_zerolen_body()
 {
+	atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs (PR 195763)"
 	atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
 	    grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
 
@@ -281,6 +282,7 @@ color_body()
 	atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
 	    grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
 
+	atf_expect_fail "GNU grep --color output does not exactly match BSD grep's"
 	atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
 	    grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw>