Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Apr 2007 11:01:28 GMT
From:      Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 118353 for review
Message-ID:  <200704181101.l3IB1SlE010247@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=118353

Change 118353 by gonzo@gonzo_jeeves on 2007/04/18 11:00:39

	o gt_pci_intr should by fiter interrupt.

Affected files ...

.. //depot/projects/mips2/src/sys/mips/mips4k/malta/gt_pci.c#6 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/mips4k/malta/gt_pci.c#6 (text+ko) ====

@@ -137,7 +137,7 @@
 	    (sc->sc_elcr >> 8) & 0xff);
 }
 
-static void
+static int
 gt_pci_intr(void *v)
 {
 	struct gt_pci_softc *sc = v;
@@ -151,7 +151,7 @@
 		irq = bus_space_read_1(sc->sc_pciio, sc->sc_ioh_icu1, PIC_OCW3);
 		if ((irq & OCW3_POLL_PENDING) == 0)
 		{
-			return;
+			return FILTER_HANDLED;
 		}
 
 		irq = OCW3_POLL_IRQ(irq);
@@ -196,6 +196,8 @@
 		bus_space_write_1(sc->sc_pciio, sc->sc_ioh_icu1, PIC_OCW2,
 		    OCW2_SELECT | OCW2_EOI | OCW2_SL | OCW2_ILS(irq));
 	}
+
+	return FILTER_HANDLED;
 }
 
 static int
@@ -351,7 +353,7 @@
 	}
 
 	if ((bus_setup_intr(dev, sc->sc_irq, INTR_TYPE_MISC,
-			    NULL, gt_pci_intr, sc, &sc->sc_ih))) {
+			    gt_pci_intr, NULL, sc, &sc->sc_ih))) {
 		device_printf(dev, 
 		    "WARNING: unable to register interrupt handler\n");
 		return ENXIO;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704181101.l3IB1SlE010247>