Date: Wed, 19 Feb 2014 13:49:59 -0800 (PST) From: Jeremy Chadwick <jdc@koitsu.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/186902: ftp/curl -- NTLM option has no effect Message-ID: <20140219214959.9329873A3B@icarus.home.lan> Resent-Message-ID: <201402192200.s1JM00UV019012@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186902
>Category: ports
>Synopsis: ftp/curl -- NTLM option has no effect
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Feb 19 22:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD icarus.home.lan 9.2-STABLE FreeBSD 9.2-STABLE #0 r260665: Tue Jan 14 19:21:13 PST 2014 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64
>Description:
The NTLM option has no effect, meaning NTLM support is still enabled
even if the NTLM option/checkbox is disabled.
I went through the port Makefile and I see nothing wrong. The option
controls use of --disable-ntlm or --enable-ntlm during configure.
However, both of these flags are no-ops in curl's configure script.
curl's autoconf/configure script allows flags of any kind to work,
e.g. --disable-tiny-brained-marmots won't throw an error or warning.
I have no idea when the curl folks removed --{disable,enable}-ntlm.
If you do ./configure --help | grep -i ntlm, you'll see there are no
such options, but there are some called --enable-ntlm-wb and
--disable-ntlm-wb, but those appear to be related to NTLM delegation
to winbind ntlm_auth (I don't know what that is).
>How-To-Repeat:
Building the port without NTLM support, then do curl -V and look at
the Features list; NTLM support will be shown.
>Fix:
My fix would be to remove the NTLM option from the Makefile entirely,
however I'm not sure about the NTLM vs. SSL engine logic located at
lines 141 to 143.
Someone may want to add something like NTLM_WB as an option, but I
don't know what the necessary logics would be (for SSL, winbind
checking, dependencies, etc.) for this to work.
I'll leave all of this up to sunpoet@ to decide.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140219214959.9329873A3B>