Date: Wed, 26 Mar 2025 21:31:41 GMT From: Enji Cooper <ngie@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 30cfebf2f089 - stable/13 - mca_log: add missing breaks when handling thresholds Message-ID: <202503262131.52QLVftx002637@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=30cfebf2f089466f9ee2c5fa25b0d47f868e3539 commit 30cfebf2f089466f9ee2c5fa25b0d47f868e3539 Author: Enji Cooper <ngie@FreeBSD.org> AuthorDate: 2025-01-29 21:24:53 +0000 Commit: Enji Cooper <ngie@FreeBSD.org> CommitDate: 2025-03-26 21:26:50 +0000 mca_log: add missing breaks when handling thresholds Per the "Intel® 64 and IA-32 Architectures Software Developer’s Manual Combined Volumes: Vol. 3B 17-7", the Green and Yellow threshold indicators are mutually exclusive. Add the missing `break` statements so they're treated that way. MFC after: 1 week Reported by: Coverity Differential Revision: https://reviews.freebsd.org/D48722 (cherry picked from commit 36d7d2044b934103ad9254cd03ea61245c16ccda) --- sys/x86/x86/mca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index dca6b935e4a3..2bc8eb0cfd4c 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -453,8 +453,10 @@ mca_log(const struct mca_record *rec) switch ((rec->mr_status & MC_STATUS_TES_STATUS) >> 53) { case 0x1: printf("(Green) "); + break; case 0x2: printf("(Yellow) "); + break; } } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503262131.52QLVftx002637>