Date: Wed, 5 Jan 2022 13:47:44 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES Message-ID: <CANCZdfpYRxdgaxVbc1xEozy7w8tbSMNYmXJTGE3veuO2VAOasQ@mail.gmail.com> In-Reply-To: <CAGudoHF_g6f2FDx_DnGCpkNRF6mK1FCPf9vet46RPUKQ618Pcg@mail.gmail.com> References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> <CAGudoHF_g6f2FDx_DnGCpkNRF6mK1FCPf9vet46RPUKQ618Pcg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik <mjguzik@gmail.com> wrote: > On 12/31/21, Warner Losh <imp@freebsd.org> wrote: > > The branch main has been updated by imp: > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4 > > > > commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2021-12-31 21:56:16 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2021-12-31 21:56:16 +0000 > > > > Add lio back to NOTES > > > > lio appears to be partially removed from this file. It's a modern > > enough > > card, so add it back. It builds everywhere. > > > > This breaks NOIP kernels: > NOIP kernels were already broken when I made this commit. I'll take a look now that emaste committed fixes for those... Warner ld: error: undefined symbol: tcp_lro_flush_all > >>> referenced by lio_droq.c > >>> lio_droq.o:(lio_droq_process_packets) > > ld: error: undefined symbol: tcp_lro_rx > >>> referenced by lio_core.c > >>> lio_core.o:(lio_push_packet) > > ld: error: undefined symbol: tcp_lro_init > >>> referenced by lio_main.c > >>> lio_main.o:(lio_attach) > > ld: error: undefined symbol: tcp_lro_free > >>> referenced by lio_main.c > >>> lio_main.o:(lio_attach) > >>> referenced by lio_main.c > >>> lio_main.o:(lio_destroy_nic_device) > > > Sponsored by: Netflix > > --- > > sys/conf/NOTES | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sys/conf/NOTES b/sys/conf/NOTES > > index 65e088cfe7c9..eded586b4491 100644 > > --- a/sys/conf/NOTES > > +++ b/sys/conf/NOTES > > @@ -1931,6 +1931,7 @@ envvar hint.fxp.0.prefer_iomap="0" > > device gem # Apple GMAC/Sun ERI/Sun GEM > > device jme # JMicron JMC250 Gigabit/JMC260 > Fast Ethernet > > device lge # Level 1 LXT1001 gigabit Ethernet > > +device lio # Support for Cavium 23XX Ethernet > adapters > > device mlxfw # Mellanox firmware update module > > device mlx5 # Shared code module between IB > and Ethernet > > device mlx5en # Mellanox ConnectX-4 and > ConnectX-4 LX > > > > > -- > Mateusz Guzik <mjguzik gmail.com> > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik <<a href="mailto:mjguzik@gmail.com">mjguzik@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 12/31/21, Warner Losh <<a href="mailto:imp@freebsd.org" target="_blank" rel="noreferrer">imp@freebsd.org</a>> wrote:<br> > The branch main has been updated by imp:<br> ><br> > URL:<br> > <a href="https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4</a><br>; ><br> > commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2021-12-31 21:56:16 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2021-12-31 21:56:16 +0000<br> ><br> > Add lio back to NOTES<br> ><br> > lio appears to be partially removed from this file. It's a modern<br> > enough<br> > card, so add it back. It builds everywhere.<br> ><br> <br> This breaks NOIP kernels:<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">NOIP kernels were already broken when I made this commit. I'll take a look now that emaste committed fixes for those...</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> ld: error: undefined symbol: tcp_lro_flush_all<br> >>> referenced by lio_droq.c<br> >>> lio_droq.o:(lio_droq_process_packets)<br> <br> ld: error: undefined symbol: tcp_lro_rx<br> >>> referenced by lio_core.c<br> >>> lio_core.o:(lio_push_packet)<br> <br> ld: error: undefined symbol: tcp_lro_init<br> >>> referenced by lio_main.c<br> >>> lio_main.o:(lio_attach)<br> <br> ld: error: undefined symbol: tcp_lro_free<br> >>> referenced by lio_main.c<br> >>> lio_main.o:(lio_attach)<br> >>> referenced by lio_main.c<br> >>> lio_main.o:(lio_destroy_nic_device)<br> <br> > Sponsored by: Netflix<br> > ---<br> > sys/conf/NOTES | 1 +<br> > 1 file changed, 1 insertion(+)<br> ><br> > diff --git a/sys/conf/NOTES b/sys/conf/NOTES<br> > index 65e088cfe7c9..eded586b4491 100644<br> > --- a/sys/conf/NOTES<br> > +++ b/sys/conf/NOTES<br> > @@ -1931,6 +1931,7 @@ envvar hint.fxp.0.prefer_iomap="0"<br> > device gem # Apple GMAC/Sun ERI/Sun GEM<br> > device jme # JMicron JMC250 Gigabit/JMC260 Fast Ethernet<br> > device lge # Level 1 LXT1001 gigabit Ethernet<br> > +device lio # Support for Cavium 23XX Ethernet adapters<br> > device mlxfw # Mellanox firmware update module<br> > device mlx5 # Shared code module between IB and Ethernet<br> > device mlx5en # Mellanox ConnectX-4 and ConnectX-4 LX<br> ><br> <br> <br> -- <br> Mateusz Guzik <mjguzik <a href="http://gmail.com" rel="noreferrer noreferrer" target="_blank">gmail.com</a>><br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpYRxdgaxVbc1xEozy7w8tbSMNYmXJTGE3veuO2VAOasQ>