Date: Sat, 30 Oct 2004 22:35:58 -0700 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Matthew Jacob <mjacob44@yahoo.com>, Bruce M Simpson <bms@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c Message-ID: <E024D6F9B48B27EB9B2BF6CE@caspian.scsiguy.com> In-Reply-To: <20041031035037.59607.qmail@web21422.mail.yahoo.com> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Shouldn't an API for adding or removing ISR's be responsible for > handling just such a race condition? bus_teardown_intr() already has these semantics, but you have to know to use it and that it should only be called without locks held since it may sleep waiting for another CPU to leave your interrupt handler. The code that was added to this driver shouldn't be necessary if the ISR is properly deregistered during suspend, detach, etc. -- Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E024D6F9B48B27EB9B2BF6CE>