Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Aug 2014 13:58:39 +0000
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r270877 - head/sys/net
Message-ID:  <1EC00F70-7E6E-448F-AE85-BE87A3C753A1@FreeBSD.org>
In-Reply-To: <201408311330.s7VDUtLH040605@svn.freebsd.org>
References:  <201408311330.s7VDUtLH040605@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 31 Aug 2014, at 13:30 , Gleb Smirnoff <glebius@FreeBSD.org> wrote:

> Author: glebius
> Date: Sun Aug 31 13:30:54 2014
> New Revision: 270877
> URL: http://svnweb.freebsd.org/changeset/base/270877
>=20
> Log:
>  Toss fields so that no padding field is required to achieve =
alignment.
>=20
> Modified:
>  head/sys/net/if_var.h
>=20
> Modified: head/sys/net/if_var.h
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/net/if_var.h	Sun Aug 31 12:48:13 2014	=
(r270876)
> +++ head/sys/net/if_var.h	Sun Aug 31 13:30:54 2014	=
(r270877)
> @@ -146,11 +146,11 @@ struct ifnet {
>=20
> 	/* Variable fields that are touched by the stack and drivers. */
> 	int	if_flags;		/* up/down, broadcast, etc. */
> +	int	if_drv_flags;		/* driver-managed status flags =
*/
> 	int	if_capabilities;	/* interface features & =
capabilities */
> 	int	if_capenable;		/* enabled features & =
capabilities */
> 	void	*if_linkmib;		/* link-type-specific MIB data =
*/
> 	size_t	if_linkmiblen;		/* length of above data */
> -	int	if_drv_flags;		/* driver-managed status flags =
*/
> 	u_int	if_refcount;		/* reference count */
>=20
> 	/* These fields are shared with struct if_data. */
> @@ -158,7 +158,6 @@ struct ifnet {
> 	uint8_t		if_addrlen;	/* media address length */
> 	uint8_t		if_hdrlen;	/* media header length */
> 	uint8_t		if_link_state;	/* current link state */
> -	uint32_t	if_spare32;

Doesn=92t this leave a gap on 64bit alignment now again?

> 	uint32_t	if_mtu;		/* maximum transmission unit */
> 	uint32_t	if_metric;	/* routing metric (external =
only) */
> 	uint64_t	if_baudrate;	/* linespeed */
>=20

=97=20
Bjoern A. Zeeb             "Come on. Learn, goddamn it.", WarGames, 1983




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1EC00F70-7E6E-448F-AE85-BE87A3C753A1>