Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Oct 2016 16:54:15 -0500
From:      Lewis Donzis <lew@perftech.com>
To:        Jilles Tjoelker <jilles@stack.nl>
Cc:        Konstantin Belousov <kostikbel@gmail.com>, Alexander Kabaev <kabaev@gmail.com>, deischen@freebsd.org, freebsd-arch@freebsd.org
Subject:   Re: mq on kqueue broken after upgrade to FreeBSD 11
Message-ID:  <B1267D82-3CA4-44E1-8AB3-AF23F77521D0@perftech.com>
In-Reply-To: <20161001201655.GA91457@stack.nl>
References:  <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan> <20161001092515.GW38409@kib.kiev.ua> <20161001201655.GA91457@stack.nl>

index | next in thread | previous in thread | raw e-mail


> On Oct 1, 2016, at 3:16 PM, Jilles Tjoelker <jilles@stack.nl> wrote:
> The idea is good, but perhaps call the function mq_getfd_np() to clarify
> it returns a file descriptor.

I have no objection, but for what it’s worth, there could be code out there that uses __mq_oshandle() simply because it’s been around for a while and has been the only way to use poll(), select(), or kevent() with an mqueue ever since an mqd_t changed from an integer to a pointer.

In our case, we have a half-dozen or so source files that reference __mq_oshandle(), but we don’t mind changing them if it’s better in the long run.  I’m merely pointing out that it’s incompatible with previous FreeBSD versions.

Thanks,
lew



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B1267D82-3CA4-44E1-8AB3-AF23F77521D0>