Date: Mon, 02 Jun 2014 17:23:15 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-10@FreeBSD.org Subject: Re: svn commit: r266970 - stable/10/sys/geom Message-ID: <538C7AC3.7030405@FreeBSD.org> In-Reply-To: <1401714438.20883.83.camel@revolution.hippie.lan> References: <201406021014.s52AE3DY033480@svn.freebsd.org> <1401714438.20883.83.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02.06.2014 17:07, Ian Lepore wrote:
>> ==============================================================================
>> --- stable/10/sys/geom/geom_event.c Mon Jun 2 07:08:34 2014 (r266969)
>> +++ stable/10/sys/geom/geom_event.c Mon Jun 2 10:14:03 2014 (r266970)
>> @@ -206,6 +206,14 @@ g_orphan_register(struct g_provider *pp)
>> KASSERT(cp->geom->orphan != NULL,
>> ("geom %s has no orphan, class %s",
>> cp->geom->name, cp->geom->class->name));
>> + /*
>> + * XXX: g_dev_orphan method does deferred destroying
>> + * and it is possible, that other event could already
>> + * call the orphan method. Check consumer's flags to
>> + * do not schedule it twice.
>> + */
>> + if (cp->flags & G_CF_ORPHAN)
>> + continue;
>> cp->flags |= G_CF_ORPHAN;
>> cp->geom->orphan(cp);
>> }
>>
>
> Why is this comment flagged with XXX? Doesn't that generally mean that
> more action or further analysis in the future is required? Nothing
> about the comment itself indicates that there's more work to do.
I suspect that there are some another places, where similar problem can
occurs. It needs more attention. I just did fix for the easy
reproducible panic.
--
WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538C7AC3.7030405>